-
Notifications
You must be signed in to change notification settings - Fork 156
update core bundle documentation for 2.0 #816
Conversation
bundles/core/configuration.rst
Outdated
only needs to be changed when configuring multiple manager registries. | ||
|
||
This setting is propagated as default value to all CMF bundles that support | ||
this setting: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i am rather surprised why the registry service name can be configured on search and simple bundle but not on any other. but as we already released them, i guess we have to leave that as is for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh i need to commit() the reviews :-)
just a litte sentence on the form_tab defintion
bundles/core/configuration.rst
Outdated
@@ -125,7 +119,8 @@ is the following configuration: | |||
|
|||
.. include:: ../_partials/persistence_phpcr_enabled.rst.inc | |||
|
|||
Enabling this setting will also automatically enable the equivalent setting in the following Bundles: | |||
This setting is propagated as default value to all CMF bundles that support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When they are installed
(composer requirer, new ...() in kernel bundles)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right. added a note for that in the introduction (as this note is repeated for each setting that can be forwarded)
@@ -1,2 +1,221 @@ | |||
CoreBundle | |||
========== | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add an hint, that this repository isn't stable atm - even when it gets stable next week.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding that hint to the introduction on the bundle
|
||
**type**: ``string`` **default**: as in above example. | ||
|
||
Defines which form tab the fields from this extension will appear in within |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not only, they also are passed into the translation so it is not a key only, it visible translated, so a non default key needs to be translated too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point, added that
part of #787