@timdeschryver There actually is a 'link', as TSESTree.Node will have a type of the given AST_NODE_TYPES value (as that's what every function is checking for).

I know it's a complex situation.
I know it is possible to do so, just can't figure out how to do so and was hoping you could help out here.
If not, I'll just leave it like this

@timdeschryver I updated isNodeOfType in 85ad91c and that seems to do what I want it to do.
Would love to have your feedback though.

Looking a bit further into it, the type predicates for union types are incorrect now. 😕🤔

isLiteral will check for

| (BigIntLiteral & { type: 'Literal' })
| (BooleanLiteral & { type: 'Literal' })
| (NumberLiteral & { type: 'Literal' })
| (NullLiteral & { type: 'Literal' })
| (RegExpLiteral & { type: 'Literal' })
| (StringLiteral & { type: 'Literal' })

which is incorrect of course, as that should be

| (BigIntLiteral & { type: 'BigIntLiteral' })
| (BooleanLiteral & { type: 'BooleanLiteral' })
| (NumberLiteral & { type: 'NumberLiteral' })
| (NullLiteral & { type: 'NullLiteral' })
| (RegExpLiteral & { type: 'RegExpLiteral' })
| (StringLiteral & { type: 'StringLiteral' })

Creating a new isNodeOfUnionType generic function (which will probably be the first implement I had) whenever we need it sounds good to me 👍

I just had a talk with @RobinMalfait and he suggested to have a look at https://www.typescriptlang.org/docs/handbook/2/mapped-types.html as this could possibly help us out here

Will check it out later today when I got some time

@MichaelDeBoey thanks for your effort around this! It's something we definitely wanted to do on v4 but didn't have time to work on.

It seems like my second try is actually correct (even for union types)! 🎉

I was assuming BigIntLiteral & { type: 'Literal' } was incorrect and should be BigIntLiteral & { type: 'BigIntLiteral' }, but:

• BigIntLiteral, BooleanLiteral, NumberLiteral, NullLiteral, RegExpLiteral & StringLiteral all have AST_NODE_TYPES.Literal and are unioned as Literal
• MemberExpressionComputedName & MemberExpressionNonComputedName both have AST_NODE_TYPES.MemberExpression as type property and are unioned as MemberExpression
• PropertyComputedName & PropertyNonComputedName both have AST_NODE_TYPES.Property as type property (see PropertyBase) and are unioned as Property

Thanks to @bmvantunes for pointing this out to me! 👊

🎉 This PR is included in version 4.0.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀