Skip to content

Repo: integrate with yarn-berry-deduplicate for fewer dependencies tree #11216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
JounQin opened this issue May 14, 2025 · 1 comment
Open

Repo: integrate with yarn-berry-deduplicate for fewer dependencies tree #11216

JounQin opened this issue May 14, 2025 · 1 comment
Labels
repo maintenance things to do with maintenance of the repo, and not with code/docs triage Waiting for team members to take a look

Comments

@JounQin
Copy link
Contributor

JounQin commented May 14, 2025 •
edited
Loading

Suggestion

yarnpkg/berry#2297 (comment)
https://github.com/christophehurpeau/yarn-deduplicate

Just add it into

typescript-eslint/package.json

Line 42 in af077a0

"postinstall": "tsx tools/scripts/postinstall.mts",

Additional Info

No response
@JounQin JounQin added triage Waiting for team members to take a look repo maintenance things to do with maintenance of the repo, and not with code/docs labels May 14, 2025
@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commented May 19, 2025 •
edited
Loading

Amusing, we're also trying to reduce the postinstall script's size for the sake of faster CI: #11204 / #11205.

Also linking for visibility, #10891 - that we're looking to move the repo over to pnpm. If this issue isn't resolved before the pnpm switch-over then we can retarget it to include pnpm dedupe.

My vote: I don't see any problem with adding this now. But, it doesn't need to be in the postinstall script. That would make it run in very CI job that installs. It should be a separate check that happens only once in CI.

@JoshuaKGoldberg JoshuaKGoldberg added accepting prs Go ahead, send a pull request that resolves this issue triage Waiting for team members to take a look and removed triage Waiting for team members to take a look accepting prs Go ahead, send a pull request that resolves this issue labels May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
repo maintenance things to do with maintenance of the repo, and not with code/docs triage Waiting for team members to take a look
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JoshuaKGoldberg @JounQin