Skip to content

Also remove pre-push hook? #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JoshuaKGoldberg opened this issue May 27, 2019 · 3 comments · Fixed by #580
Closed

Also remove pre-push hook? #556

JoshuaKGoldberg opened this issue May 27, 2019 · 3 comments · Fixed by #580
Labels
question Questions! (i.e. not a bug / enhancment / documentation)

Comments

@JoshuaKGoldberg
Copy link
Member

Following #259: it's inconvenient to wait for a full lint + typecheck after every git push. CI builds reinforce them anyway. Can they be removed, please?

@bradzacher
Copy link
Member

If you're confident that they're correct can't you just use --no-verify on push?
I like to have them there because it can help to catch users that haven't done those super basic checks (i.e. don't have a prettier plugin installed in their editor).
The typecheck step could be removed if it's too slow. The lint too if it's still too slow.

But one of the most common forms of CI build failures is formatting, so I'd like to at a minimum keep that. That at least saves time by not having to re-review PRs and such.

@bradzacher bradzacher added the question Questions! (i.e. not a bug / enhancment / documentation) label May 28, 2019
@JoshuaKGoldberg
Copy link
Member Author

can't you just use --no-verify on push?

Yes, but it's a pain to forget it.

not having to re-review PRs and such

Interesting: from a reviewer/maintainer perspective, do you re-review when a build is failing?

I'll try to send a PR soon to remove typecheck and linting, thanks!

@bradzacher
Copy link
Member

bradzacher commented May 28, 2019

If we approve a PR, and then a new commit comes in (that's not a straight merge commit), github dismisses the review (because it's stale - the code has changed).

So if we approve then the user commits to fix a formatting issue, it'll dismiss the review and we'll have to be conscious of it and re-approve. That or we request changes then have to approve once they fix the formatting, which is a bit cumbersome too.

Having it checked pre-push helps guard against people that "fire and forget" their PRs and only update them once they're commented on.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
question Questions! (i.e. not a bug / enhancment / documentation)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants