Skip to content

Remove visitorKeys backwards compat export from typescript-estree #6087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JoshuaKGoldberg opened this issue Nov 25, 2022 · 1 comment
Closed

Remove visitorKeys backwards compat export from typescript-estree #6087

JoshuaKGoldberg opened this issue Nov 25, 2022 · 1 comment
Assignees
@JoshuaKGoldberg
Labels
accepting prs Go ahead, send a pull request that resolves this issue breaking change This change will require a new major version to be released package: typescript-estree Issues related to @typescript-eslint/typescript-estree
Milestone
6.0.0

Comments

@JoshuaKGoldberg
Copy link
Member

Suggestion

typescript-eslint/packages/typescript-estree/src/index.ts

Lines 19 to 20 in 87a2736

// re-export for backwards-compat
export { visitorKeys } from '@typescript-eslint/visitor-keys';

Let's kill this for v6? 🔪 😈
@JoshuaKGoldberg JoshuaKGoldberg added package: typescript-estree Issues related to @typescript-eslint/typescript-estree triage Waiting for team members to take a look breaking change This change will require a new major version to be released labels Nov 25, 2022
@bradzacher bradzacher added accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for team members to take a look labels Nov 27, 2022
@bradzacher bradzacher added this to the 6.0.0 milestone Nov 27, 2022
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Dec 17, 2022
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Dec 17, 2022
Merged
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg changed the title Remove visitorKeys backwards compat export from typescript-estree? Remove visitorKeys backwards compat export from typescript-estree Dec 17, 2022
@JoshuaKGoldberg
Copy link
Member Author

#6242 was merged into the v6 branch. 👍

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
accepting prs Go ahead, send a pull request that resolves this issue breaking change This change will require a new major version to be released package: typescript-estree Issues related to @typescript-eslint/typescript-estree
Projects
None yet
Milestone
6.0.0
Development

No branches or pull requests
2 participants
@JoshuaKGoldberg @bradzacher