Skip to content

Repo: Migrate to Nx executors for more commands #6142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JoshuaKGoldberg opened this issue Dec 1, 2022 · 1 comment
Closed

Repo: Migrate to Nx executors for more commands #6142

JoshuaKGoldberg opened this issue Dec 1, 2022 · 1 comment
Assignees
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@JoshuaKGoldberg
Copy link
Member

Suggestion

We've previously migrated to Nx for linting (#6038). Let's do that for more commands.

Looking at testing in particular, we might consider using the Nrwl Jest plugin!

nx g @nrwl/jest:jest-project --project=<project-name>
"test": {
  "executor": "@nrwl/jest:jest",
  "outputs": ["{workspaceRoot}/coverage/{projectRoot}"],
  "options": {
    "jestConfig": "packages/typescript-estree/jest.config.ts",
    "passWithNoTests": true
  }
}

However, we should note that this might not get us much benefit. We're already running Jest and the Nx runner is going to do that in a slightly different way. We'll see.

@JoshuaKGoldberg JoshuaKGoldberg added repo maintenance things to do with maintenance of the repo, and not with code/docs accepting prs Go ahead, send a pull request that resolves this issue labels Dec 1, 2022
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Dec 1, 2022
@JoshuaKGoldberg JoshuaKGoldberg changed the title Repo: Migrate to Nx executors for more command Repo: Migrate to Nx executors for more commands Dec 1, 2022
@JoshuaKGoldberg
Copy link
Member Author

Yeah, I played with this a bit locally and it seemed pretty equivalent. FYI @JamesHenry I'll close this out.

But if we ever see benefits from commands to migrate to Nx, then I'd be up for switching over. 🙂

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Development

No branches or pull requests

1 participant