-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Bump ESLint major version in Peer Dependencies (eslint 6.0) #644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We'll bump it as soon as we start testing against it. For posterity's sake: https://eslint.org/docs/6.0.0/user-guide/migrating-to-6.0.0 |
I did a quick check and it seems that the parser relies on |
@mrmckeb - no an in-development, unreleased rule depends on that file, but it's not requried anywhere and not exposed to users, so it doesn't matter. We already fixed the file dependency issues before the 6.0 release because some users were using the beta releases and reported issues. This plugin will probably "just work" with eslint v6. |
OK, thanks @bradzacher. I had that fail when attempting to upgrade Create React App, but we may have been on an outdated version - I didn't investigate far as I was actually working on something else and it was a side-quest. |
What code were you trying to parse?
npm install
What did you expect to happen?
no warnings
What actually happened?
Versions
@typescript-eslint/parser
TypeScript
ESLint
6.0.0
node
12.4.0
npm
6.9.0
The text was updated successfully, but these errors were encountered: