Skip to content

Bump ESLint major version in Peer Dependencies (eslint 6.0) #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SalvatorePreviti opened this issue Jun 24, 2019 · 4 comments · Fixed by #645
Closed

Bump ESLint major version in Peer Dependencies (eslint 6.0) #644

SalvatorePreviti opened this issue Jun 24, 2019 · 4 comments · Fixed by #645
Labels
dependencies Issue about dependencies of the package has pr there is a PR raised to close this package: parser Issues related to @typescript-eslint/parser

Comments

@SalvatorePreviti
Copy link

What code were you trying to parse?

npm install

What did you expect to happen?

no warnings

What actually happened?

npm WARN @typescript-eslint/eslint-plugin@1.11.0 requires a peer of eslint@^5.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN @typescript-eslint/parser@1.11.0 requires a peer of eslint@^5.0.0 but none is installed. You must install peer dependencies yourself.

Versions

package version
@typescript-eslint/parser 1.11.0
TypeScript latest
ESLint 6.0.0
node 12.4.0
npm 6.9.0
@SalvatorePreviti SalvatorePreviti added package: parser Issues related to @typescript-eslint/parser triage Waiting for team members to take a look labels Jun 24, 2019
@bradzacher bradzacher added dependencies Issue about dependencies of the package and removed triage Waiting for team members to take a look labels Jun 24, 2019
@bradzacher
Copy link
Member

We'll bump it as soon as we start testing against it.
We need to review the release notes and action things appropriately.

For posterity's sake: https://eslint.org/docs/6.0.0/user-guide/migrating-to-6.0.0

@mrmckeb
Copy link

mrmckeb commented Jun 24, 2019

I did a quick check and it seems that the parser relies on eslint/lib/util/ast-utils which seems to have been removed from ESLint.

@bradzacher
Copy link
Member

@mrmckeb - no an in-development, unreleased rule depends on that file, but it's not requried anywhere and not exposed to users, so it doesn't matter.

We already fixed the file dependency issues before the 6.0 release because some users were using the beta releases and reported issues.

This plugin will probably "just work" with eslint v6.
But until we've reviewed the changelog accordingly and tested it, we won't be bumping the version range.

@bradzacher bradzacher added 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge has pr there is a PR raised to close this and removed 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labels Jun 25, 2019
@mrmckeb
Copy link

mrmckeb commented Jun 25, 2019

OK, thanks @bradzacher. I had that fail when attempting to upgrade Create React App, but we may have been on an outdated version - I didn't investigate far as I was actually working on something else and it was a side-quest.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Issue about dependencies of the package has pr there is a PR raised to close this package: parser Issues related to @typescript-eslint/parser
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants