Skip to content

Repo: Docusaurus builds are broken on main #7165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JoshuaKGoldberg opened this issue Jul 6, 2023 · 6 comments
Closed

Repo: Docusaurus builds are broken on main #7165

JoshuaKGoldberg opened this issue Jul 6, 2023 · 6 comments
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@JoshuaKGoldberg
Copy link
Member

Suggestion

Trying yarn start on main locally:

[INFO] Starting the development server...
[ERROR] Error: 
  x Export assignment cannot be used when targeting ECMAScript modules. Consider using `export default` or another module format instead.
     ,-[/Users/josh/repos/typescript-eslint/packages/website/docusaurusConfig.ts:302:1]
 302 |   ],
 303 | };
 304 | 
 305 | export = config;
     : ^^^^^^^^^^^^^^^^
     `----

sigh

Guessing an automatic update of something broke running Docusaurus. Will have to bisect through the Git history to see when this happened...
@JoshuaKGoldberg JoshuaKGoldberg added triage Waiting for team members to take a look repo maintenance things to do with maintenance of the repo, and not with code/docs bug Something isn't working accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for team members to take a look labels Jul 6, 2023
@JoshuaKGoldberg
Copy link
Member Author

@Josh-Cena don't suppose you happen to have a pointer on this? I should be able to take a look tonight or tomorrow, but the sooner we can fix this the better...

@JoshuaKGoldberg
Copy link
Member Author

Hmm, might be a nested SWC thing. In the v6 branch, removing swc: true from docusaurus.config.js fixed things.

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jul 6, 2023
Closed
3 tasks
@rubiesonthesky
Copy link
Contributor

rubiesonthesky commented Jul 6, 2023 •
edited
Loading

I think they broke on ts 5.1 update #7088 . I tried to check when it changes from website commit log. If nothing else it could be starting point for bisecting.

edit: it seems while I was writing and doing something else, there is already better solution.. :)

@JoshuaKGoldberg
Copy link
Member Author

Good callout, thanks @rubiesonthesky! The removal of swc helps, but does feel like a surface-level thing.

@rubiesonthesky
Copy link
Contributor

Ts 5.1 commit changed website module from commonjs to nodeNext in tsconfig. This could match with that error.

@rubiesonthesky rubiesonthesky mentioned this issue Jul 10, 2023
Closed
3 tasks
@JoshuaKGoldberg
Copy link
Member Author

Oop, I fixed this in v6 which is now merged to main. So this issue can be closed.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
2 participants
@rubiesonthesky @JoshuaKGoldberg