Skip to content

Repo: postinstall scripts with tsx fail on latest Node.js 18.19.0 #8045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
auvred opened this issue Dec 9, 2023 · 3 comments · Fixed by #8048
Closed

Repo: postinstall scripts with tsx fail on latest Node.js 18.19.0 #8045

auvred opened this issue Dec 9, 2023 · 3 comments · Fixed by #8048
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@auvred
Copy link
Member

auvred commented Dec 9, 2023

Suggestion

CI failure: https://github.com/typescript-eslint/typescript-eslint/actions/runs/7151333167/job/19475573267?pr=8044#step:3:186
stderr: https://cloud.nx.app/runs/KoN80i59UA/task/repo-tools%3Apostinstall-script

The reason is the same as in #8025

According to #8025 (comment):

We wouldn't be able to drop Node.js 16 support until our next major version, as that'd be a breaking change. So for now we can either use something other than tsx or pin the Node.js version in Netlify to <=18.18.2.

We can't just bump tsx. We can do one of the following:

  1. Patch tsx with changes from fix: adjust feature detection for node 18.19 loader changes privatenumber/tsx#422
  2. Use something other than tsx
  3. Pin Node.js to 18.18.2

I assume the third option is undesirable, because we would have to pin Node.js to 18.18.2 everywhere

If we choose the second option, here is a good starting point: https://github.com/privatenumber/ts-runtime-comparison

I can open two draft PRs for 1 and 2 options, so we can compare which one would be better
@auvred auvred added repo maintenance things to do with maintenance of the repo, and not with code/docs triage Waiting for team members to take a look labels Dec 9, 2023
@auvred auvred changed the title Repo: PR check "Run Unit Tests with Experimental TSServer" fails on latest Node.js 18.19.0 Repo: postinstall scripts withtsx fail on latest Node.js 18.19.0 Dec 9, 2023
@auvred auvred changed the title Repo: postinstall scripts withtsx fail on latest Node.js 18.19.0 Repo: postinstall scripts with tsx fail on latest Node.js 18.19.0 Dec 9, 2023
@bradzacher
Copy link
Member

I would assume that can just bump tsx and use --ignore-engines in the install for now.
No contributor should be using node 16 but we can provide this advice in the docs for now.

If that doesn't work then we can consider another action. We could also just build things and stop using live transpiration 😅

@auvred auvred mentioned this issue Dec 11, 2023
Merged
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg added accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for team members to take a look labels Dec 11, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Dec 11, 2023
Merged
3 tasks
@JoshuaKGoldberg
Copy link
Member

stop using live transpiration

😭. I hope we can get tsx or an equivalent to work...!

@JoshuaKGoldberg
Copy link
Member

Ah, fixed in privatenumber/tsx#421 -> privatenumber/tsx#422. Nice.

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Dec 11, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(deps): update tsx to 4.6.2 auvred/typescript-eslint
3 participants
@JoshuaKGoldberg @bradzacher @auvred