Skip to content

Repo: postinstall scripts with tsx fail on latest Node.js 18.19.0 #8045

Closed
@auvred

Description

@auvred

Suggestion

CI failure: https://github.com/typescript-eslint/typescript-eslint/actions/runs/7151333167/job/19475573267?pr=8044#step:3:186
stderr: https://cloud.nx.app/runs/KoN80i59UA/task/repo-tools%3Apostinstall-script

The reason is the same as in #8025

According to #8025 (comment):

We wouldn't be able to drop Node.js 16 support until our next major version, as that'd be a breaking change. So for now we can either use something other than tsx or pin the Node.js version in Netlify to <=18.18.2.

We can't just bump tsx. We can do one of the following:

  1. Patch tsx with changes from fix: adjust feature detection for node 18.19 loader changes privatenumber/tsx#422
  2. Use something other than tsx
  3. Pin Node.js to 18.18.2

I assume the third option is undesirable, because we would have to pin Node.js to 18.18.2 everywhere

If we choose the second option, here is a good starting point: https://github.com/privatenumber/ts-runtime-comparison

I can open two draft PRs for 1 and 2 options, so we can compare which one would be better

Metadata

Metadata

Assignees

No one assigned

    Labels

    accepting prsGo ahead, send a pull request that resolves this issuerepo maintenancethings to do with maintenance of the repo, and not with code/docs

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions