Skip to content

Enhancement: Display tsconfig errors in playground #8580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
4 tasks done
yeonjuan opened this issue Feb 29, 2024 · 3 comments · May be fixed by #10991
Open
4 tasks done

Enhancement: Display tsconfig errors in playground #8580

yeonjuan opened this issue Feb 29, 2024 · 3 comments · May be fixed by #10991
Labels
accepting prs Go ahead, send a pull request that resolves this issue enhancement New feature or request website: playground

Comments

@yeonjuan
Copy link
Contributor

Before You File a Proposal Please Confirm You Have Done The Following...

Relevant Package

website

My proposal is suitable for this project

  • I believe my proposal would be useful to the broader TypeScript community (meaning it is not a niche proposal).

Description

It would be nice if playground displays tsconfig error messages in the "Errors" tab.
Currently, the "Errors" tab shows a "All is ok!" message, but the browser console shows an error.

스크린샷 2024-03-01 오전 12 27 24

This makes it difficult to accurately reproduce the issue. (#7693 (comment))

Additional Info

No response
@yeonjuan yeonjuan added enhancement New feature or request triage Waiting for team members to take a look labels Feb 29, 2024
@bradzacher bradzacher added accepting prs Go ahead, send a pull request that resolves this issue website: playground and removed triage Waiting for team members to take a look labels Feb 29, 2024
@armano2 armano2 assigned armano2 and unassigned armano2 Mar 2, 2024
@jsfm01
Copy link
Contributor

jsfm01 commented Mar 11, 2024

Hi @bradzacher :)
I am new here, would this be a good first issue? Please let me now!

@armano2
Copy link
Collaborator

armano2 commented Mar 11, 2024 •
edited by bradzacher
Loading

this issue should be relatively easy to solve

those logs are emitted here:

typescript-eslint/packages/website/src/components/linter/createLinter.ts

Line 162 in 8400939

console.error(e);

typescript-eslint/packages/website/src/components/linter/createLinter.ts

Line 150 in 8400939

console.error(e);

@jsfm01
Copy link
Contributor

jsfm01 commented Mar 11, 2024 •
edited
Loading

@armano2 Thanks a lot for answering! Could you please tell me with a bit more detail how can this be done correctly? ErrorsViewer is responsible for displaying the messages (correct?), so how can I display the error message from createLinter?

arkapratimc added a commit to arkapratimc/typescript-eslint that referenced this issue Mar 13, 2024
@arkapratimc
fix: Display tsconfig errors in playground
838fa00 
fixes: typescript-eslint#8580
@arkapratimc arkapratimc mentioned this issue Mar 13, 2024
Closed
3 tasks
@ronami ronami mentioned this issue Jan 1, 2025
Closed
2 tasks
@developer-bandi developer-bandi linked a pull request Mar 23, 2025 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue enhancement New feature or request website: playground
Projects
None yet
Milestone
No milestone
4 participants
@armano2 @bradzacher @yeonjuan @jsfm01