Skip to content

Enhancement: Raise minimum versions of dependencies for v8 #8929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JoshuaKGoldberg opened this issue Apr 15, 2024 · 8 comments
Closed

Enhancement: Raise minimum versions of dependencies for v8 #8929

JoshuaKGoldberg opened this issue Apr 15, 2024 · 8 comments
Assignees
@JoshuaKGoldberg
Labels
accepting prs Go ahead, send a pull request that resolves this issue breaking change This change will require a new major version to be released enhancement New feature or request locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.
Milestone
8.0.0

Comments

@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commented Apr 15, 2024 •
edited
Loading

Overview

Our v8 release is coming soon, and with that comes the regular expected bumping of our minimum dependency versions! 🎉

To recap, raising the minimum versions of ESLint, Node, and TypeScript allows us to support fewer divergent sets of available APIs. That lets us work faster, ship less code, and take up fewer resources in our own builds. See https://typescript-eslint.io/users/dependency-versions for what version ranges we support.

This issue tracks raising the minimum versions of those three dependencies. Expecting roughly a ~summer 2024 release of v8:

  • ESLint: will remain supporting v8
  • Node: will remain supporting ^18 and >=20
  • TypeScript: will bump from >=4.7 to >=4.8

Overall, this should be a pretty small change that doesn't cause much disruption. We can expect very few users to still require TypeScript 4.7.

Putting in triage so other folks on @typescript-eslint/triage-team can make sure I got this right. 😄

💖
@JoshuaKGoldberg JoshuaKGoldberg added enhancement New feature or request triage Waiting for team members to take a look breaking change This change will require a new major version to be released labels Apr 15, 2024
@JoshuaKGoldberg JoshuaKGoldberg added this to the 8.0.0 milestone Apr 15, 2024
@bradzacher
Copy link
Member

Node: will remain supporting ^18 and >=20

We should probably bump this to match ESLint again.
https://github.com/eslint/eslint/blob/main/package.json#L178-L180

They're using "^18.18.0 || ^20.9.0 || >=21.1.0 (ours is just ^18.18.0 || >=20.0.0)
I'm fine not explicitly encoding the v21 range (we don't care about odd majors) - but the v20 should probs update, I think.

@bradzacher
Copy link
Member

ESLint: will remain supporting v8

It's currently at ^8.56.0. This should probably bump to ^8.57.0.
Really hit home that "You should update your deps".
This also is the absolute final release of v8 and included a few QOL things to help with v9 compat. Doesn't impact us but it's a nice-to-have for users (eg it helps vscode interop between the two).

@rubiesonthesky
Copy link
Contributor

What is the policy for Typescript version requirements? I think that bump is fine and I’m just curious if there is some guideline how you define it. :)

@bradzacher
Copy link
Member

@rubiesonthesky https://typescript-eslint.io/users/dependency-versions#typescript

@rubiesonthesky
Copy link
Contributor

@bradzacher thanks! I tried to search this info under maintenance and then didn’t use search 🤦

@iambumblehead

This comment has been minimized.

Sign in to view
@bradzacher
Copy link
Member

@iambumblehead unrelated. This is minimum versions. Not maximum versions.

You want the pinned issue #8211

@JoshuaKGoldberg JoshuaKGoldberg added accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for team members to take a look labels Apr 22, 2024
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Apr 22, 2024
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Apr 22, 2024
Merged
3 tasks
@JoshuaKGoldberg
Copy link
Member Author

#8973 was merged into v8. ✅

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Apr 29, 2024
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2024
@bradzacher bradzacher added the locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. label Apr 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
accepting prs Go ahead, send a pull request that resolves this issue breaking change This change will require a new major version to be released enhancement New feature or request locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.
Projects
None yet
Milestone
8.0.0
Development

No branches or pull requests
4 participants
@iambumblehead @rubiesonthesky @JoshuaKGoldberg @bradzacher