Skip to content

Enhancement(utils): Swap FlatESLint-ESLint, FlatRuleTester-RuleTester in API #8970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
4 tasks done
JoshuaKGoldberg opened this issue Apr 22, 2024 · 1 comment
Closed
4 tasks done

Enhancement(utils): Swap FlatESLint-ESLint, FlatRuleTester-RuleTester in API #8970

JoshuaKGoldberg opened this issue Apr 22, 2024 · 1 comment
Labels
accepting prs Go ahead, send a pull request that resolves this issue breaking change This change will require a new major version to be released enhancement New feature or request locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.
Milestone
8.0.0

Comments

@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commented Apr 22, 2024 •
edited
Loading

Before You File a Proposal Please Confirm You Have Done The Following...

Relevant Package

utils

My proposal is suitable for this project

  • I believe my proposal would be useful to the broader TypeScript community (meaning it is not a niche proposal).

Description

From #8211: we have references to what FlatESLint and FlatRuleTester, which are the old terms for what ESLint now just calls ESLint and RuleTester, respectively. We'll need to:

  1. Make sure any export like LegacyESLint as ESLint is exported as Legacy*
  2. Make sure any export like FlatESLint is renamed to FlatESLint as ESLint (or just ESLint)

I suppose we could also remove the Legacy* classes too? Though ESLint v9 still does support the legacy configs if you opt into them...

Additional Info

This is not a good first issue. Someone who's already familiar with the classes & utilities in question should tackle this.

💖
@JoshuaKGoldberg JoshuaKGoldberg added enhancement New feature or request triage Waiting for team members to take a look breaking change This change will require a new major version to be released accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for team members to take a look labels Apr 22, 2024
@JoshuaKGoldberg JoshuaKGoldberg added this to the 8.0.0 milestone Apr 22, 2024
This was referenced Apr 22, 2024
Closed
Merged
@JoshuaKGoldberg
Copy link
Member Author

#8972 was merged into v8. ✅

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2024
@bradzacher bradzacher added the locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. label Apr 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue breaking change This change will require a new major version to be released enhancement New feature or request locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.
Projects
None yet
Milestone
8.0.0
Development

No branches or pull requests
2 participants
@JoshuaKGoldberg @bradzacher