Skip to content

feat(eslint-plugin): [no-misused-object-likes] add rule #10104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

abrahamguo
Copy link
Contributor

@abrahamguo abrahamguo commented Oct 4, 2024

PR Checklist

Overview

Based on #9369.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @abrahamguo!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@abrahamguo abrahamguo marked this pull request as draft October 4, 2024 14:46
Copy link

netlify bot commented Oct 4, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 8dec282
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6711014f5f6ce1000861a74b
😎 Deploy Preview https://deploy-preview-10104--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 94 (🟢 up 3 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@JoshuaKGoldberg
Copy link
Member

👋 Just checking in @abrahamguo, anything we can help with?

@abrahamguo
Copy link
Contributor Author

Nothing I need at the moment! I should be able to get back to this PR in the next few days.

@JoshuaKGoldberg
Copy link
Member

Ping @abrahamguo - are you still planning on working on this? #6807 is getting some comments from folks also interested. It'd be good to either get this in review or let other folks work on it instead soon?

@abrahamguo
Copy link
Contributor Author

No, unfortunately I haven't had time to work on these lately, so I'm happy to pass the torch!

@JoshuaKGoldberg
Copy link
Member

You got it - thanks for getting this started!

Closing out this PR for now. To anybody reading this: feel free to use this as a reference. If you end up taking on any code from the PR, please include a co-authored-by attribution. Cheers!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule proposal: Prevent Object.values(...) usage with Map
2 participants