Skip to content

feat(eslint-plugin): [no-misused-objects-like] add new rule #10573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

ronami
Copy link
Member

@ronami ronami commented Dec 30, 2024

PR Checklist

Overview

This PR continues #10104, co-authored with @abrahamguo.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @ronami!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Dec 30, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit b335a78
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6773299aac8cc2000834dc19
😎 Deploy Preview https://deploy-preview-10573--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🟢 up 8 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Dec 30, 2024

View your CI Pipeline Execution ↗ for commit b335a78.

Command Status Duration Result
nx test eslint-plugin ✅ Succeeded 5m 56s View ↗
nx test eslint-plugin --coverage=false ✅ Succeeded 7m 32s View ↗
nx test type-utils ✅ Succeeded <1s View ↗
nx run types:build ✅ Succeeded <1s View ↗
nx test visitor-keys ✅ Succeeded <1s View ↗
nx test typescript-eslint ✅ Succeeded 4s View ↗
nx test utils ✅ Succeeded <1s View ↗
nx run-many --target=build --exclude website --... ✅ Succeeded 26s View ↗
Additional runs (24) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2024-12-30 23:35:14 UTC

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.94%. Comparing base (c27399b) to head (b335a78).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10573      +/-   ##
==========================================
+ Coverage   86.90%   86.94%   +0.03%     
==========================================
  Files         446      447       +1     
  Lines       15506    15547      +41     
  Branches     4518     4529      +11     
==========================================
+ Hits        13476    13517      +41     
  Misses       1675     1675              
  Partials      355      355              
Flag Coverage Δ
unittest 86.94% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...eslint-plugin/src/rules/no-misused-object-likes.ts 100.00% <100.00%> (ø)

@ronami ronami closed this Dec 31, 2024
@ronami ronami deleted the no-misused-object-likes-rule branch December 31, 2024 06:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule proposal: Prevent Object.values(...) usage with Map
2 participants