fix(eslint-plugin): [no-unnecessary-template] report on types #10207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, @omril1! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
added 2 commits
October 25, 2024 19:21
|
👋 @omril1 are you planning on continuing/un-drafting this soon? Anything we can help with? |
I'll get to it in the next couple of days. |
…rt-on-template-types
…10306) chore(deps): update dependency webpack to v5.96.0 Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
chore(deps): update dependency knip to v5.36.1 Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…int#10297) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…#10317) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…#10320) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…pt-eslint#10192) * feat(eslint-plugin): added related-getter-setter-pairs rule * Fixed stack popping * Fixed stack popping * Correction: reported getter always has return type annotation * Correction: reported getter always has return type annotation * Update packages/eslint-plugin/docs/rules/related-getter-setter-pairs.mdx Co-authored-by: Joshua Chen <sidachen2003@gmail.com> --------- Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
* feat: add to svg * feat: add the Bluesky * chore: add cspell like Bluesky * fix: icon * fix: sort social links
…eslint#10051) * initial implementation * tests * docs * more tests * use checker.typeToString() over getTypeName() * use link * oops * add tests * remove unnecessary typescript 5.4 warning * adjust format to new rules * update error message to be more concise * match implementation to be inline with no-unsafe-* rules * rework tests * refactor * update snapshots * fix error message showing original type instead of asserted type * update snapshots * add a warning for object stubbing on test files * fix linting * adjust test to lint fixes * simplify type comparison * rework code-comments and rename variables * rework the opening paragraph to make it more beginner-friendly * Update packages/eslint-plugin/docs/rules/no-unsafe-type-assertion.mdx Co-authored-by: Kirk Waiblinger <kirk.waiblinger@gmail.com> * fix: narrow/widen in description --------- Co-authored-by: Kirk Waiblinger <kirk.waiblinger@gmail.com> Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
Co-authored-by: typescript-eslint[bot] <typescript-eslint[bot]@users.noreply.github.com>
…nnecessary-template--report-on-template-types
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10207 +/- ##
==========================================
+ Coverage 86.63% 86.73% +0.10%
==========================================
Files 433 434 +1
Lines 15202 15275 +73
Branches 4439 4463 +24
==========================================
+ Hits 13170 13249 +79
+ Misses 1675 1670 -5
+ Partials 357 356 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Overview
Copied the existing logic and modified it to work on template types instead of just template literal values