feat(eslint-plugin): [prefer-nullish-coalescing] fix detection of `ignoreConditionalTests` involving boolean `!` operator #10299

developer-bandi · 2024-11-07T00:42:01Z

PR Checklist

Addresses an existing open issue: fixes Bug: [prefer-nullish-coalescing] ignoreConditionalTests doesn't ignore the boolean ! operator in a condition #10284
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

Since we maintain the same logic as the ignoreBooleanCoercion option, should we add the same logic to this option as well?

let a: string | undefined;
let b: string | undefined;

Boolean(!!(a || b)) 
Boolean(!(a || b))

typescript-eslint · 2024-11-07T00:42:04Z

Thanks for the PR, @developer-bandi!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2024-11-07T00:42:17Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`8bd626d`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/67347e1ad386df0008191153
😎 Deploy Preview	https://deploy-preview-10299--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 99 (no change from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

nx-cloud · 2024-11-07T00:42:54Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8bd626d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

codecov · 2024-11-07T00:57:52Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.60%. Comparing base (90617a6) to head (8bd626d).
Report is 15 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #10299      +/-   ##
==========================================
+ Coverage   86.57%   86.60%   +0.02%     
==========================================
  Files         431      432       +1     
  Lines       15198    15166      -32     
  Branches     4421     4428       +7     
==========================================
- Hits        13158    13134      -24     
+ Misses       1683     1675       -8     
  Partials      357      357

Flag	Coverage Δ
unittest	`86.60% <100.00%> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...lint-plugin/src/rules/prefer-nullish-coalescing.ts	`95.59% <100.00%> (+0.08%)`	⬆️

... and 27 files with indirect coverage changes

kirkwaiblinger · 2024-11-07T17:06:04Z

Hey! merging from main for ya to fix the build errors

…ssion

packages/eslint-plugin/src/rules/prefer-nullish-coalescing.ts

…ttps://github.com/developer-bandi/typescript-eslint into feature/prefer-nullish-coalescing-unaryexpression

kirkwaiblinger

thanks!

kirkwaiblinger · 2024-11-11T09:13:05Z

Since we maintain the same logic as the ignoreBooleanCoercion option, should we add the same logic to this option as well?
let a: string | undefined;
let b: string | undefined;

Boolean(!!(a || b)) 
Boolean(!(a || b)) 

Yeah, probably a good idea to do this tbh.

kirkwaiblinger

What you have looks good, but I think it would be good to implement your suggestion in #10299 (comment)

…ssion

kirkwaiblinger

kirkwaiblinger · 2024-11-11T18:25:23Z

packages/eslint-plugin/tests/rules/prefer-nullish-coalescing.test.ts

+let a: string | undefined;
+let b: string | undefined;
+
+Boolean(!(a || b));


oh, hmm. I hate to do this. But actually, now that I'm thinking harder about this, I don't think we want this. This would be unambiguously better to write as !Boolean(a || b), so the ! really is the sort of implicit coercion that ignoreBooleanCoercion constructor is trying to force you to use Boolean on instead.

So sorry to change request changes one way and then request they be undone, but would you mind reverting the ignoreBooleanCoercion changes?

kirkwaiblinger

Changed my mind about #10299 (review), sorry! 🫣

See #10299 (comment)

…ttps://github.com/developer-bandi/typescript-eslint into feature/prefer-nullish-coalescing-unaryexpression

developer-bandi · 2024-11-13T10:25:08Z

Thank you. I have reflected this.

kirkwaiblinger

Great! And sorry again for my previous mistaken review!

@developer-bandi

##### [v8.15.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8150-2024-11-18) ##### 🚀 Features - **eslint-plugin:** \[prefer-nullish-coalescing] fix detection of `ignoreConditionalTests` involving boolean `!` operator ([#10299](typescript-eslint/typescript-eslint#10299)) - **eslint-plugin:** new rule `no-unsafe-type-assertion` ([#10051](typescript-eslint/typescript-eslint#10051)) - **eslint-plugin:** added related-getter-setter-pairs rule ([#10192](typescript-eslint/typescript-eslint#10192)) ##### 🩹 Fixes - **utils:** add defaultOptions to meta in rule ([#10339](typescript-eslint/typescript-eslint#10339)) - **eslint-plugin:** report deprecations used in default export ([#10330](typescript-eslint/typescript-eslint#10330)) - **eslint-plugin:** \[explicit-module-boundary-types] and \[explicit-function-return-type] don't report on `as const satisfies` ([#10315](typescript-eslint/typescript-eslint#10315)) - **eslint-plugin:** \[await-thenable, return-await] don't flag awaiting unconstrained type parameter as unnecessary ([#10314](typescript-eslint/typescript-eslint#10314)) - **eslint-plugin:** \[consistent-indexed-object-style] handle circular mapped types ([#10301](typescript-eslint/typescript-eslint#10301)) ##### ❤️ Thank You - Josh Goldberg ✨ - Kim Sang Du [@developer-bandi](https://github.com/developer-bandi) - Luis Sebastian Urrutia Fuentes [@LuisUrrutia](https://github.com/LuisUrrutia) - Phillip Huang - Ronen Amiel - Szydlak [@wszydlak](https://github.com/wszydlak) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

@developer-bandi

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.14.0 | 8.15.0 | | npm | @typescript-eslint/parser | 8.14.0 | 8.15.0 | ## [v8.15.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8150-2024-11-18) ##### 🚀 Features - **eslint-plugin:** \[prefer-nullish-coalescing] fix detection of `ignoreConditionalTests` involving boolean `!` operator ([#10299](typescript-eslint/typescript-eslint#10299)) - **eslint-plugin:** new rule `no-unsafe-type-assertion` ([#10051](typescript-eslint/typescript-eslint#10051)) - **eslint-plugin:** added related-getter-setter-pairs rule ([#10192](typescript-eslint/typescript-eslint#10192)) ##### 🩹 Fixes - **utils:** add defaultOptions to meta in rule ([#10339](typescript-eslint/typescript-eslint#10339)) - **eslint-plugin:** report deprecations used in default export ([#10330](typescript-eslint/typescript-eslint#10330)) - **eslint-plugin:** \[explicit-module-boundary-types] and \[explicit-function-return-type] don't report on `as const satisfies` ([#10315](typescript-eslint/typescript-eslint#10315)) - **eslint-plugin:** \[await-thenable, return-await] don't flag awaiting unconstrained type parameter as unnecessary ([#10314](typescript-eslint/typescript-eslint#10314)) - **eslint-plugin:** \[consistent-indexed-object-style] handle circular mapped types ([#10301](typescript-eslint/typescript-eslint#10301)) ##### ❤️ Thank You - Josh Goldberg ✨ - Kim Sang Du [@developer-bandi](https://github.com/developer-bandi) - Luis Sebastian Urrutia Fuentes [@LuisUrrutia](https://github.com/LuisUrrutia) - Phillip Huang - Ronen Amiel - Szydlak [@wszydlak](https://github.com/wszydlak) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

fix: add unaryExpression to recursive

9d490f5

kirkwaiblinger changed the title ~~feat(eslint-plugin): [prefer-nullish-coalescing] modifies the unaryExpression type to run recursively.~~ feat(eslint-plugin): [prefer-nullish-coalescing] modifies the unaryExpression type to run recursively Nov 7, 2024

Merge branch 'main' into feature/prefer-nullish-coalescing-unaryexpre…

5fcfd02

…ssion

kirkwaiblinger reviewed Nov 8, 2024

View reviewed changes

packages/eslint-plugin/src/rules/prefer-nullish-coalescing.ts Outdated Show resolved Hide resolved

developer-bandi added 2 commits November 9, 2024 01:44

fix: only apply ! operator

3f16099

Merge branch 'feature/prefer-nullish-coalescing-unaryexpression' of h…

1ddd9bf

…ttps://github.com/developer-bandi/typescript-eslint into feature/prefer-nullish-coalescing-unaryexpression

developer-bandi requested a review from kirkwaiblinger November 8, 2024 16:46

kirkwaiblinger approved these changes Nov 11, 2024

View reviewed changes

kirkwaiblinger added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Nov 11, 2024

kirkwaiblinger requested changes Nov 11, 2024

View reviewed changes

kirkwaiblinger removed the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Nov 11, 2024

kirkwaiblinger changed the title ~~feat(eslint-plugin): [prefer-nullish-coalescing] modifies the unaryExpression type to run recursively~~ feat(eslint-plugin): [prefer-nullish-coalescing] fix detection of ignoreConditionalTests involving boolean ! operator Nov 11, 2024

feat: add same logic to boolean

707188e

developer-bandi requested a review from kirkwaiblinger November 11, 2024 12:38

Merge branch 'main' into feature/prefer-nullish-coalescing-unaryexpre…

24eddcf

…ssion

kirkwaiblinger approved these changes Nov 11, 2024

View reviewed changes

kirkwaiblinger added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Nov 11, 2024

kirkwaiblinger reviewed Nov 11, 2024

View reviewed changes

kirkwaiblinger requested changes Nov 11, 2024

View reviewed changes

kirkwaiblinger removed the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Nov 11, 2024

developer-bandi added 2 commits November 13, 2024 19:22

fix: revert ignoreBooleanCoercion option logic

6b4dbda

Merge branch 'feature/prefer-nullish-coalescing-unaryexpression' of h…

8bd626d

…ttps://github.com/developer-bandi/typescript-eslint into feature/prefer-nullish-coalescing-unaryexpression

developer-bandi requested a review from kirkwaiblinger November 13, 2024 10:24

kirkwaiblinger approved these changes Nov 15, 2024

View reviewed changes

kirkwaiblinger added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Nov 15, 2024

bradzacher approved these changes Nov 16, 2024

View reviewed changes

bradzacher added the bug Something isn't working label Nov 16, 2024

bradzacher merged commit a7746fb into typescript-eslint:main Nov 16, 2024
63 of 67 checks passed

github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(eslint-plugin): [prefer-nullish-coalescing] fix detection of `ignoreConditionalTests` involving boolean `!` operator #10299

feat(eslint-plugin): [prefer-nullish-coalescing] fix detection of `ignoreConditionalTests` involving boolean `!` operator #10299

developer-bandi commented Nov 7, 2024 •

edited

Loading

typescript-eslint bot commented Nov 7, 2024

netlify bot commented Nov 7, 2024 •

edited

Loading

nx-cloud bot commented Nov 7, 2024 •

edited

Loading

codecov bot commented Nov 7, 2024 •

edited

Loading

kirkwaiblinger commented Nov 7, 2024

kirkwaiblinger left a comment

kirkwaiblinger commented Nov 11, 2024

kirkwaiblinger left a comment

kirkwaiblinger left a comment

kirkwaiblinger Nov 11, 2024

kirkwaiblinger left a comment •

edited

Loading

developer-bandi commented Nov 13, 2024

kirkwaiblinger left a comment

feat(eslint-plugin): [prefer-nullish-coalescing] fix detection of ignoreConditionalTests involving boolean ! operator #10299

feat(eslint-plugin): [prefer-nullish-coalescing] fix detection of ignoreConditionalTests involving boolean ! operator #10299

Conversation

developer-bandi commented Nov 7, 2024 • edited Loading

PR Checklist

Overview

typescript-eslint bot commented Nov 7, 2024

netlify bot commented Nov 7, 2024 • edited Loading

✅ Deploy Preview for typescript-eslint ready!

nx-cloud bot commented Nov 7, 2024 • edited Loading

☁️ Nx Cloud Report

codecov bot commented Nov 7, 2024 • edited Loading

Codecov Report

kirkwaiblinger commented Nov 7, 2024

kirkwaiblinger left a comment

Choose a reason for hiding this comment

kirkwaiblinger commented Nov 11, 2024

kirkwaiblinger left a comment

Choose a reason for hiding this comment

kirkwaiblinger left a comment

Choose a reason for hiding this comment

kirkwaiblinger Nov 11, 2024

Choose a reason for hiding this comment

kirkwaiblinger left a comment • edited Loading

Choose a reason for hiding this comment

developer-bandi commented Nov 13, 2024

kirkwaiblinger left a comment

Choose a reason for hiding this comment

feat(eslint-plugin): [prefer-nullish-coalescing] fix detection of `ignoreConditionalTests` involving boolean `!` operator #10299

feat(eslint-plugin): [prefer-nullish-coalescing] fix detection of `ignoreConditionalTests` involving boolean `!` operator #10299

developer-bandi commented Nov 7, 2024 •

edited

Loading

netlify bot commented Nov 7, 2024 •

edited

Loading

nx-cloud bot commented Nov 7, 2024 •

edited

Loading

codecov bot commented Nov 7, 2024 •

edited

Loading

kirkwaiblinger left a comment •

edited

Loading