fix(eslint-plugin): [no-unnecessary-condition] don't flag values of an unconstrained or valid type parameter #10473

ronami · 2024-12-07T18:13:56Z

PR Checklist

Addresses an existing open issue: fixes Bug: [no-unnecessary-condition] don't flag values of an unconstrained or valid type parameter #10442
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

This PR addresses #10442 and handles a potential return type being a type constraint.

The PR suffers from the same issues around getConstrainedTypeAtLocation described by @kirkwaiblinger on #10438 and requires a small workaround.

Note that no-unnecessary-condition makes a lot of use of getConstrainedTypeAtLocation, but going over them roughly, I couldn't find additional bugs around unconstrained type parameters.

…alid type parameter

typescript-eslint · 2024-12-07T18:13:58Z

Thanks for the PR, @ronami!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2024-12-07T18:14:14Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`ff59a13`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/67607a6b06fd6900082923c8
😎 Deploy Preview	https://deploy-preview-10473--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 100 (🟢 up 22 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

nx-cloud · 2024-12-07T18:14:50Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ff59a13. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

packages/eslint-plugin/src/rules/no-unnecessary-condition.ts

codecov · 2024-12-07T18:29:48Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.80%. Comparing base (cb0ef9c) to head (ff59a13).
Report is 26 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #10473      +/-   ##
==========================================
+ Coverage   86.77%   86.80%   +0.02%     
==========================================
  Files         444      445       +1     
  Lines       15335    15379      +44     
  Branches     4468     4481      +13     
==========================================
+ Hits        13307    13349      +42     
- Misses       1673     1675       +2     
  Partials      355      355

Flag	Coverage Δ
unittest	`86.80% <100.00%> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...slint-plugin/src/rules/no-unnecessary-condition.ts	`99.24% <100.00%> (+0.04%)`	⬆️

... and 15 files with indirect coverage changes

JoshuaKGoldberg

Nice! Just requesting changes on a bit of cleanup for the older code.

packages/eslint-plugin/src/rules/no-unnecessary-condition.ts

JoshuaKGoldberg

One last touchup, since you're humoring me 😄

packages/eslint-plugin/src/rules/no-unnecessary-condition.ts

…etected

JoshuaKGoldberg

LGTM! I think this is ready if you are ✨

ronami · 2024-12-16T17:35:16Z

LGTM! I think this is ready if you are ✨

I think this is ready, it's a lot better thanks to your help! ❤️

packages/eslint-plugin/src/rules/no-unnecessary-condition.ts

kirkwaiblinger

🚀

Bug is solved and the existing code is better for it, too.

@controversial

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.18.1 | 8.18.2 | | npm | @typescript-eslint/parser | 8.18.1 | 8.18.2 | ## [v8.18.2](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8182-2024-12-23) ##### 🩹 Fixes - **eslint-plugin:** \[no-unnecessary-condition] handle noUncheckedIndexedAccess true ([#10514](typescript-eslint/typescript-eslint#10514)) - **eslint-plugin:** \[consistent-type-assertions] allow default assertionStyle option ([#10512](typescript-eslint/typescript-eslint#10512)) - **eslint-plugin:** \[no-unnecessary-type-arguments] handle type/value context ([#10503](typescript-eslint/typescript-eslint#10503)) - **eslint-plugin:** \[no-unsafe-type-assertion] fix for unsafe assertion to a constrained type parameter ([#10461](typescript-eslint/typescript-eslint#10461)) - **eslint-plugin:** \[consistent-indexed-object-style] use a suggestion over an auto-fix if can't reliably determine that produced index signature is valid ([#10490](typescript-eslint/typescript-eslint#10490)) - **eslint-plugin:** \[no-unnecessary-condition] don't flag values of an unconstrained or valid type parameter ([#10473](typescript-eslint/typescript-eslint#10473)) - **eslint-plugin:** \[prefer-reduce-type-parameter] don't report cases in which the fix results in a type error ([#10494](typescript-eslint/typescript-eslint#10494)) - **eslint-plugin:** \[no-deprecated] not reporting usages of deprecated declared constants as object value ([#10498](typescript-eslint/typescript-eslint#10498)) ##### ❤️ Thank You - Luke Deen Taylor [@controversial](https://github.com/controversial) - Ronen Amiel - Scott O'Hara - YeonJuan [@yeonjuan](https://github.com/yeonjuan) - Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

@controversial

##### [v8.18.2](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8182-2024-12-23) ##### 🩹 Fixes - **eslint-plugin:** \[no-unnecessary-condition] handle noUncheckedIndexedAccess true ([#10514](typescript-eslint/typescript-eslint#10514)) - **eslint-plugin:** \[consistent-type-assertions] allow default assertionStyle option ([#10512](typescript-eslint/typescript-eslint#10512)) - **eslint-plugin:** \[no-unnecessary-type-arguments] handle type/value context ([#10503](typescript-eslint/typescript-eslint#10503)) - **eslint-plugin:** \[no-unsafe-type-assertion] fix for unsafe assertion to a constrained type parameter ([#10461](typescript-eslint/typescript-eslint#10461)) - **eslint-plugin:** \[consistent-indexed-object-style] use a suggestion over an auto-fix if can't reliably determine that produced index signature is valid ([#10490](typescript-eslint/typescript-eslint#10490)) - **eslint-plugin:** \[no-unnecessary-condition] don't flag values of an unconstrained or valid type parameter ([#10473](typescript-eslint/typescript-eslint#10473)) - **eslint-plugin:** \[prefer-reduce-type-parameter] don't report cases in which the fix results in a type error ([#10494](typescript-eslint/typescript-eslint#10494)) - **eslint-plugin:** \[no-deprecated] not reporting usages of deprecated declared constants as object value ([#10498](typescript-eslint/typescript-eslint#10498)) ##### ❤️ Thank You - Luke Deen Taylor [@controversial](https://github.com/controversial) - Ronen Amiel - Scott O'Hara - YeonJuan [@yeonjuan](https://github.com/yeonjuan) - Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

[no-unnecessary-condition] don't flag values of an unconstrained or v…

40a0961

…alid type parameter

ronami commented Dec 7, 2024

View reviewed changes

packages/eslint-plugin/src/rules/no-unnecessary-condition.ts Outdated Show resolved Hide resolved

ronami commented Dec 7, 2024

View reviewed changes

packages/eslint-plugin/src/rules/no-unnecessary-condition.ts Show resolved Hide resolved

ronami marked this pull request as ready for review December 7, 2024 18:30

ronami changed the title ~~fix(eslint-plugin): [no-unnecessary-condition] don't flag values of an unconstrained or v…~~ fix(eslint-plugin): [no-unnecessary-condition] don't flag values of an unconstrained or valid type parameter Dec 7, 2024

JoshuaKGoldberg requested changes Dec 14, 2024

View reviewed changes

packages/eslint-plugin/src/rules/no-unnecessary-condition.ts Outdated Show resolved Hide resolved

packages/eslint-plugin/src/rules/no-unnecessary-condition.ts Show resolved Hide resolved

JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Dec 14, 2024

use a much simpelr for loop instead of several confusing .some() checks

991ff23

ronami requested a review from JoshuaKGoldberg December 14, 2024 20:00

github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Dec 14, 2024

JoshuaKGoldberg requested changes Dec 14, 2024

View reviewed changes

packages/eslint-plugin/src/rules/no-unnecessary-condition.ts Show resolved Hide resolved

JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Dec 14, 2024

ronami requested a review from JoshuaKGoldberg December 15, 2024 19:13

github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Dec 15, 2024

bail early if both a possibly-truthy and a possibly-falsy have been d…

d33a7d4

…etected

JoshuaKGoldberg previously approved these changes Dec 16, 2024

View reviewed changes

JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Dec 16, 2024

kirkwaiblinger reviewed Dec 16, 2024

View reviewed changes

packages/eslint-plugin/src/rules/no-unnecessary-condition.ts Show resolved Hide resolved

put back code that checks non-callables

ff59a13

ronami dismissed JoshuaKGoldberg’s stale review via ff59a13 December 16, 2024 19:07

kirkwaiblinger approved these changes Dec 16, 2024

View reviewed changes

JoshuaKGoldberg merged commit 8ca9cba into typescript-eslint:main Dec 21, 2024
62 checks passed

ronami deleted the no-unnecessary-condition-dont-flag-unconstrained-or-valid-constraint branch December 21, 2024 14:51

github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(eslint-plugin): [no-unnecessary-condition] don't flag values of an unconstrained or valid type parameter #10473

fix(eslint-plugin): [no-unnecessary-condition] don't flag values of an unconstrained or valid type parameter #10473

ronami commented Dec 7, 2024 •

edited

Loading

typescript-eslint bot commented Dec 7, 2024

netlify bot commented Dec 7, 2024 •

edited

Loading

nx-cloud bot commented Dec 7, 2024 •

edited

Loading

codecov bot commented Dec 7, 2024 •

edited

Loading

JoshuaKGoldberg left a comment

JoshuaKGoldberg left a comment

JoshuaKGoldberg left a comment

ronami commented Dec 16, 2024

kirkwaiblinger left a comment

fix(eslint-plugin): [no-unnecessary-condition] don't flag values of an unconstrained or valid type parameter #10473

fix(eslint-plugin): [no-unnecessary-condition] don't flag values of an unconstrained or valid type parameter #10473

Conversation

ronami commented Dec 7, 2024 • edited Loading

PR Checklist

Overview

typescript-eslint bot commented Dec 7, 2024

netlify bot commented Dec 7, 2024 • edited Loading

✅ Deploy Preview for typescript-eslint ready!

nx-cloud bot commented Dec 7, 2024 • edited Loading

☁️ Nx Cloud Report

codecov bot commented Dec 7, 2024 • edited Loading

Codecov Report

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

ronami commented Dec 16, 2024

kirkwaiblinger left a comment

Choose a reason for hiding this comment

ronami commented Dec 7, 2024 •

edited

Loading

netlify bot commented Dec 7, 2024 •

edited

Loading

nx-cloud bot commented Dec 7, 2024 •

edited

Loading

codecov bot commented Dec 7, 2024 •

edited

Loading