Skip to content

feat(parser): add standalone isolatedDeclarations option #10499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 23, 2025
Merged

feat(parser): add standalone isolatedDeclarations option #10499

merged 2 commits into from
Jan 23, 2025

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Dec 14, 2024 •
edited
Loading

PR Checklist

Overview

Throwing up as reference for #10001 -> #10572.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Dec 14, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 3c2e3c2
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/678e5a4035c9350008b1ad35
😎 Deploy Preview https://deploy-preview-10499--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 93 (🔴 down 5 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Dec 14, 2024 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 3c2e3c2.

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 7m 31s View ↗
nx test eslint-plugin ✅ Succeeded 6m 20s View ↗
nx test utils ✅ Succeeded 4s View ↗
nx run types:build ✅ Succeeded <1s View ↗
nx test visitor-keys ✅ Succeeded 2s View ↗
nx test typescript-eslint ✅ Succeeded 4s View ↗
nx run-many --target=build --exclude website --... ✅ Succeeded 53s View ↗
nx test type-utils ✅ Succeeded 18s View ↗
Additional runs (24) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-01-20 14:35:09 UTC

@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Dec 14, 2024
Closed
2 tasks
@codecov Codecov
Copy link

codecov bot commented Dec 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.77%. Comparing base (690fbb8) to head (9901829).
Report is 3 commits behind head on main.

❗ Current head 9901829 differs from pull request most recent head 3c2e3c2

Please upload reports for the commit 3c2e3c2 to get more accurate results.

Files with missing lines Patch % Lines
...ages/typescript-estree/src/createParserServices.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10499      +/-   ##
==========================================
- Coverage   87.16%   86.77%   -0.39%     
==========================================
  Files         448      445       -3     
  Lines       15587    15357     -230     
  Branches     4552     4473      -79     
==========================================
- Hits        13586    13326     -260     
- Misses       1645     1675      +30     
  Partials      356      356
Flag Coverage Δ
unittest 86.77% <0.00%> (-0.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/scope-manager/src/analyze.ts 61.11% <ø> (ø)
...ages/typescript-estree/src/createParserServices.ts 54.54% <0.00%> (-5.46%) ⬇️

... and 119 files with indirect coverage changes

@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Dec 30, 2024
Closed
4 tasks
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review January 13, 2025 12:42
@JoshuaKGoldberg JoshuaKGoldberg merged commit a885343 into typescript-eslint:main Jan 23, 2025
59 of 60 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kirkwaiblinger kirkwaiblinger kirkwaiblinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement(parser): Add isolatedDeclarations as compiler option
2 participants
@JoshuaKGoldberg @kirkwaiblinger