chore(visitor-keys): migrate from jest to vitest
#10773
Conversation
|
Thanks for the PR, @aryaemami59! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
View your CI Pipeline Execution ↗ for commit e7ad033.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10773 +/- ##
==========================================
+ Coverage 88.03% 88.12% +0.09%
==========================================
Files 470 470
Lines 16801 16929 +128
Branches 4745 4746 +1
==========================================
+ Hits 14790 14919 +129
+ Misses 1664 1663 -1
Partials 347 347
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
81bf89a to
0620b48
Compare
62a825e to
e14025d
Compare
|
Marking as blocked on #10582. We'd like to normalize test scripts & coverage calculations before making the jump in individual packages. |
b18bd2f to
008698e
Compare
|
this one looks good to me 👍 |
|
|
||
| vite: false, | ||
|
|
There was a problem hiding this comment.
It doesn't change the result but since we have vite in our devDependencies, the vite plugin for knip still infers that that this is a vite project which is not accurate, on top of that knip has to do a little bit less work which makes things a teeny tiny bit faster.
…t-eslint into chore/visitor-keys-vitest-migration
…t-eslint into chore/visitor-keys-vitest-migration
d1f57a7
into
typescript-eslint:main
PR Checklist
Overview