fix(eslint-plugin): [no-array-constructor] remove optional chaining exemption #10963

developer-bandi · 2025-03-17T13:57:40Z

PR Checklist

Addresses an existing open issue: fixes Bug: [no-array-constructor] Does not detect Array call with optional chaining #10933
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

remove optional chaining logic and change test case

typescript-eslint · 2025-03-17T13:57:43Z

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2025-03-17T13:57:58Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`de18cb9`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/67e55fc685f28d0008ad3d9c
😎 Deploy Preview	https://deploy-preview-10963--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 99 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

nx-cloud · 2025-03-17T13:58:33Z

View your CI Pipeline Execution ↗ for commit de18cb9.

Command	Status	Duration	Result
`nx run integration-tests:test`	❌ Failed	2m 21s	View ↗
`nx test eslint-plugin`	✅ Succeeded	7m 59s	View ↗
`nx run eslint-plugin:test -- --coverage`	✅ Succeeded	6m 13s	View ↗
`nx test utils`	✅ Succeeded	23s	View ↗
`nx run types:build`	✅ Succeeded	<1s	View ↗
`nx test type-utils`	✅ Succeeded	<1s	View ↗
`nx run-many --target=build --exclude website --...`	✅ Succeeded	21s	View ↗
`nx test typescript-estree`	✅ Succeeded	1m 18s	View ↗
`Additional runs (25)`	✅ Succeeded	...	View ↗

☁️ Nx Cloud last updated this comment at 2025-03-27 15:19:50 UTC

codecov · 2025-03-17T14:14:20Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.97%. Comparing base (543d36c) to head (e8be03c).
Report is 15 commits behind head on main.

❗ Current head e8be03c differs from pull request most recent head de18cb9

Please upload reports for the commit de18cb9 to get more accurate results.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #10963      +/-   ##
==========================================
+ Coverage   87.58%   87.97%   +0.38%     
==========================================
  Files         470      470              
  Lines       16095    16709     +614     
  Branches     4668     4711      +43     
==========================================
+ Hits        14097    14699     +602     
- Misses       1642     1664      +22     
+ Partials      356      346      -10

Flag	Coverage Δ
unittest	`87.97% <100.00%> (+0.38%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...es/eslint-plugin/src/rules/no-array-constructor.ts	`100.00% <100.00%> (ø)`

... and 14 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JoshuaKGoldberg

Progress 💪

JoshuaKGoldberg · 2025-03-24T13:05:34Z

packages/eslint-plugin/src/rules/no-array-constructor.ts

-            const preambleLength = node.callee.range[1] - node.range[0];
+            const preambleLength =
+              node.parent.type === AST_NODE_TYPES.ChainExpression
+                ? node.callee.range[1] + 2 - node.range[0]


+ 2

[Testing] 😬 Hardcoded lengths like '?'.length & equivalent are a bit dangerous to rely on. They tend to be broken over time by AST oddities like comments and whitespace. Since this rule logic is newly dependent on character lengths, could you please add some tests to make sure this is working as intended in those edge cases?

Here's a "fun" one:

/* a */ /* b */ Array /* c */ /* d */ ?. /* e */ /* f */ () /* g */ /* h */

Added test code by referencing upstream and improved it to avoid hardcoding.

JoshuaKGoldberg

LGTM, thanks! 🚀

I'll note that the fixers do drop some comments, but that's an existing issue. Filed: #11013

@dbarabashh

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.27.0 | 8.29.0 | | npm | @typescript-eslint/parser | 8.27.0 | 8.29.0 | ## [v8.29.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8290-2025-03-31) ##### 🚀 Features - **eslint-plugin:** \[prefer-nullish-coalescing] create `ignoreIfStatements` option ([#11000](typescript-eslint/typescript-eslint#11000)) ##### 🩹 Fixes - **eslint-plugin:** \[no-array-constructor] remove optional chaining exemption ([#10963](typescript-eslint/typescript-eslint#10963)) - **eslint-plugin:** support arbitrary extensions in definition files ([#10957](typescript-eslint/typescript-eslint#10957)) - **eslint-plugin:** \[prefer-for-of] fix false positive when using erasable type syntax within update expressions ([#10981](typescript-eslint/typescript-eslint#10981)) - **eslint-plugin:** \[use-unknown-in-catch-callback-variable] remove fixable property ([#10993](typescript-eslint/typescript-eslint#10993)) - **eslint-plugin:** \[no-unnecessary-condition] don't report on unnecessary optional array index access when `noUncheckedIndexedAccess` is enabled ([#10961](typescript-eslint/typescript-eslint#10961)) ##### ❤️ Thank You - Dima Barabash [@dbarabashh](https://github.com/dbarabashh) - Kim Sang Du [@developer-bandi](https://github.com/developer-bandi) - Olivier Zalmanski [@OlivierZal](https://github.com/OlivierZal) - Ronen Amiel - Yannick Decat [@mho22](https://github.com/mho22) - zyoshoka [@zyoshoka](https://github.com/zyoshoka) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.28.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8280-2025-03-24) ##### 🚀 Features - **eslint-plugin:** \[prefer-nullish-coalescing] support `if` statement assignment (`??=`) and fix several minor bugs ([#10861](typescript-eslint/typescript-eslint#10861)) ##### 🩹 Fixes - **eslint-plugin:** \[no-unsafe-function-type] remove fixable property ([#10986](typescript-eslint/typescript-eslint#10986)) ##### ❤️ Thank You - Olivier Zalmanski [@OlivierZal](https://github.com/OlivierZal) - Yannick Decat [@mho22](https://github.com/mho22) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

@dbarabashh

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.27.0 | 8.29.0 | | npm | @typescript-eslint/parser | 8.27.0 | 8.29.0 | ## [v8.29.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8290-2025-03-31) ##### 🚀 Features - **eslint-plugin:** \[prefer-nullish-coalescing] create `ignoreIfStatements` option ([#11000](typescript-eslint/typescript-eslint#11000)) ##### 🩹 Fixes - **eslint-plugin:** \[no-array-constructor] remove optional chaining exemption ([#10963](typescript-eslint/typescript-eslint#10963)) - **eslint-plugin:** support arbitrary extensions in definition files ([#10957](typescript-eslint/typescript-eslint#10957)) - **eslint-plugin:** \[prefer-for-of] fix false positive when using erasable type syntax within update expressions ([#10981](typescript-eslint/typescript-eslint#10981)) - **eslint-plugin:** \[use-unknown-in-catch-callback-variable] remove fixable property ([#10993](typescript-eslint/typescript-eslint#10993)) - **eslint-plugin:** \[no-unnecessary-condition] don't report on unnecessary optional array index access when `noUncheckedIndexedAccess` is enabled ([#10961](typescript-eslint/typescript-eslint#10961)) ##### ❤️ Thank You - Dima Barabash [@dbarabashh](https://github.com/dbarabashh) - Kim Sang Du [@developer-bandi](https://github.com/developer-bandi) - Olivier Zalmanski [@OlivierZal](https://github.com/OlivierZal) - Ronen Amiel - Yannick Decat [@mho22](https://github.com/mho22) - zyoshoka [@zyoshoka](https://github.com/zyoshoka) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.28.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8280-2025-03-24) ##### 🚀 Features - **eslint-plugin:** \[prefer-nullish-coalescing] support `if` statement assignment (`??=`) and fix several minor bugs ([#10861](typescript-eslint/typescript-eslint#10861)) ##### 🩹 Fixes - **eslint-plugin:** \[no-unsafe-function-type] remove fixable property ([#10986](typescript-eslint/typescript-eslint#10986)) ##### ❤️ Thank You - Olivier Zalmanski [@OlivierZal](https://github.com/OlivierZal) - Yannick Decat [@mho22](https://github.com/mho22) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

…xemption (typescript-eslint#10963) * fix: remove optional chaining * fix: add space, coment add case * fix: testcase error

fix: remove optional chaining

e8be03c

JoshuaKGoldberg changed the title ~~fix(eslint-plugin): [no-array-constructor] remove optional chaining~~ fix(eslint-plugin): [no-array-constructor] remove optional chaining exemption Mar 24, 2025

JoshuaKGoldberg requested changes Mar 24, 2025

View reviewed changes

JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Mar 24, 2025

fix: add space, coment add case

63ffec8

developer-bandi requested a review from JoshuaKGoldberg March 25, 2025 17:44

github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Mar 25, 2025

fix: testcase error

de18cb9

JoshuaKGoldberg approved these changes Mar 31, 2025

View reviewed changes

JoshuaKGoldberg merged commit c548aa7 into typescript-eslint:main Mar 31, 2025
54 of 55 checks passed

github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(eslint-plugin): [no-array-constructor] remove optional chaining exemption #10963

fix(eslint-plugin): [no-array-constructor] remove optional chaining exemption #10963

Uh oh!

developer-bandi commented Mar 17, 2025

Uh oh!

typescript-eslint bot commented Mar 17, 2025

Uh oh!

netlify bot commented Mar 17, 2025 •

edited

Loading

Uh oh!

nx-cloud bot commented Mar 17, 2025 •

edited

Loading

Uh oh!

codecov bot commented Mar 17, 2025 •

edited

Loading

Uh oh!

JoshuaKGoldberg left a comment

Uh oh!

JoshuaKGoldberg Mar 24, 2025

Uh oh!

developer-bandi Mar 25, 2025

Uh oh!

JoshuaKGoldberg left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fix(eslint-plugin): [no-array-constructor] remove optional chaining exemption #10963

fix(eslint-plugin): [no-array-constructor] remove optional chaining exemption #10963

Uh oh!

Conversation

developer-bandi commented Mar 17, 2025

PR Checklist

Overview

Uh oh!

typescript-eslint bot commented Mar 17, 2025

Uh oh!

netlify bot commented Mar 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for typescript-eslint ready!

Uh oh!

nx-cloud bot commented Mar 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Mar 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

JoshuaKGoldberg Mar 24, 2025

Choose a reason for hiding this comment

Uh oh!

developer-bandi Mar 25, 2025

Choose a reason for hiding this comment

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

netlify bot commented Mar 17, 2025 •

edited

Loading

nx-cloud bot commented Mar 17, 2025 •

edited

Loading

codecov bot commented Mar 17, 2025 •

edited

Loading