Skip to content

fix(eslint-plugin): [prefer-for-of] fix false positive when using erasable type syntax within update expressions #10981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2025
Merged

fix(eslint-plugin): [prefer-for-of] fix false positive when using erasable type syntax within update expressions #10981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ccfdc9c
fix(eslint-plugin): [prefer-for-of] fix false positive when using non…
zyoshoka Mar 21, 2025
c2c9d6a
fix(eslint-plugin): fix `isAssignee` function to handle any erasable …
zyoshoka Mar 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions packages/eslint-plugin/src/util/isAssignee.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,5 +53,16 @@ export function isAssignee(node: TSESTree.Node): boolean {
return true;
}

// (a[i] as number)++, [...a[i]!] = [0], etc.
if (
(parent.type === AST_NODE_TYPES.TSNonNullExpression ||
parent.type === AST_NODE_TYPES.TSAsExpression ||
parent.type === AST_NODE_TYPES.TSTypeAssertion ||
parent.type === AST_NODE_TYPES.TSSatisfiesExpression) &&
isAssignee(parent)
) {
return true;
}

return false;
}
45 changes: 45 additions & 0 deletions packages/eslint-plugin/tests/rules/prefer-for-of.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,46 @@ for (let i = 0; i < arr.length; i++) {
}
`,
`
for (let i = 0; i < arr.length; i++) {
arr[i]++;
}
`,
`
for (let i = 0; i < arr.length; i++) {
arr[i]!++;
}
`,
`
for (let i = 0; i < arr.length; i++) {
arr[i]!!!++;
}
`,
`
for (let i = 0; i < arr.length; i++) {
(arr[i] as number)++;
}
`,
`
for (let i = 0; i < arr.length; i++) {
(<number>arr[i])++;
}
`,
`
for (let i = 0; i < arr.length; i++) {
(arr[i] as unknown as number)++;
}
`,
`
for (let i = 0; i < arr.length; i++) {
(arr[i] satisfies number)++;
}
`,
`
for (let i = 0; i < arr.length; i++) {
(arr[i]! satisfies number)++;
}
`,
`
for (let i = 0; i < arr.length; i++) {
[arr[i]] = [1];
}
Expand All @@ -149,6 +189,11 @@ for (let i = 0; i < arr.length; i++) {
}
`,
`
for (let i = 0; i < arr.length; i++) {
[...arr[i]!] = [1];
}
`,
`
for (let i = 0; i < arr.length; i++) {
({ foo: arr[i] }) = { foo: 0 };
}
Expand Down
Loading