Skip to content

fix(eslint-plugin): don’t mark declare class as unused #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 22, 2019
Merged

fix(eslint-plugin): don’t mark declare class as unused #110

merged 2 commits into from
Jan 22, 2019

Conversation

j-f1
Copy link
Contributor

@j-f1 j-f1 commented Jan 21, 2019

Fixes #106.

@j-f1 j-f1 requested a review from armano2 January 21, 2019 20:04
@codecov
Copy link

codecov bot commented Jan 21, 2019 •
edited
Loading

Codecov Report

Merging #110 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master   #110      +/-   ##
========================================
+ Coverage   94.99%    95%   +0.01%     
========================================
  Files          48     48              
  Lines        2479   2484       +5     
  Branches      381    381              
========================================
+ Hits         2355   2360       +5     
  Misses         75     75              
  Partials       49     49
Impacted Files Coverage Δ
packages/eslint-plugin/lib/rules/no-unused-vars.js 100% <100%> (ø) ⬆️

armano2
armano2 suggested changes Jan 21, 2019
View reviewed changes
Copy link
Collaborator

@armano2 armano2 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will fix issue with declare class Foo but it will not solve false positives from #106 (comment)

for sure this is improvement and with this small request about else everything looks fine

@j-f1 j-f1 merged commit 5841cd2 into master Jan 22, 2019
@j-f1 j-f1 deleted the declare-class-is-used branch January 22, 2019 12:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@armano2 armano2 armano2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[no-unused-vars] Don’t mark declare class expressions as unused
2 participants
@j-f1 @armano2