Skip to content

chore: remove unused downlevel-dts #11034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 14, 2025
Merged

chore: remove unused downlevel-dts #11034

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
93b9358
chore: remove unused downlevel-dts
JoshuaKGoldberg Apr 7, 2025
3ac4da0
check in lockfile change too
JoshuaKGoldberg Apr 7, 2025
5b1ede0
Also remove typesVersions
JoshuaKGoldberg Apr 8, 2025
def4d2d
Merge branch 'main'
JoshuaKGoldberg Apr 8, 2025
af01389
Apply suggestions from code review
JoshuaKGoldberg Apr 9, 2025
9ce1cc5
more rimraf and _ts
JoshuaKGoldberg Apr 9, 2025
f6d7e95
Merge branch 'main' into remove-downlevel-dts
JoshuaKGoldberg Apr 11, 2025
741ba53
Merge branch 'main'
JoshuaKGoldberg Apr 14, 2025
c4e843d
Merge branch 'main'
JoshuaKGoldberg Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,17 +73,10 @@ jspm_packages/
.DS_Store
.idea
dist
_ts3.4
_ts4.2
*.tsbuildinfo
.watchmanconfig
.rollup.cache

# the downlevel-dts output folders
_ts3.4
_ts4.2
_ts4.3

# Files copied as part of the build
packages/types/src/generated/**/*.ts

Expand Down
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,6 @@
"console-fail-test": "^0.5.0",
"cross-fetch": "^4.0.0",
"cspell": "^8.15.2",
"downlevel-dts": ">=0.11.0",
"eslint": "^9.15.0",
"eslint-plugin-eslint-plugin": "^6.3.1",
"eslint-plugin-import": "^2.31.0",
Expand Down
12 changes: 1 addition & 11 deletions packages/parser/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
"files": [
"dist",
"!*.tsbuildinfo",
"_ts4.3",
"README.md",
"LICENSE"
],
Expand Down Expand Up @@ -41,9 +40,8 @@
],
"scripts": {
"build": "tsc -b tsconfig.build.json",
"postbuild": "downlevel-dts dist _ts4.3/dist --to=4.3",
"clean": "tsc -b tsconfig.build.json --clean",
"postclean": "rimraf dist/ _ts4.3/ coverage/",
"postclean": "rimraf dist/ coverage/",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: is there a reason the suggestion added /s at the end? I can never keep track which tools prefer to exclude or include them 😄

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just to be explicit about the fact that they're directories.

"format": "prettier --write \"./**/*.{ts,mts,cts,tsx,js,mjs,cjs,jsx,json,md,css}\" --ignore-path ../../.prettierignore",
"lint": "npx nx lint",
"test": "vitest --run --config=$INIT_CWD/vitest.config.mts",
Expand All @@ -62,7 +60,6 @@
},
"devDependencies": {
"@vitest/coverage-v8": "^3.1.1",
"downlevel-dts": "*",
"glob": "*",
"prettier": "^3.2.5",
"rimraf": "*",
Expand All @@ -72,12 +69,5 @@
"funding": {
"type": "opencollective",
"url": "https://opencollective.com/typescript-eslint"
},
"typesVersions": {
"<4.7": {
"*": [
"_ts4.3/*"
]
}
}
}
11 changes: 1 addition & 10 deletions packages/rule-tester/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
"files": [
"dist",
"!*.tsbuildinfo",
"_ts4.2",
"README.md",
"LICENSE"
],
Expand Down Expand Up @@ -37,9 +36,8 @@
],
"scripts": {
"build": "tsc -b tsconfig.build.json",
"postbuild": "downlevel-dts dist _ts4.2/dist --to=4.2",
"clean": "tsc -b tsconfig.build.json --clean",
"postclean": "rimraf dist && rimraf _ts3.4 && rimraf coverage",
"postclean": "rimraf dist/ coverage/",
"format": "prettier --write \"./**/*.{ts,mts,cts,tsx,js,mjs,cjs,jsx,json,md,css}\" --ignore-path ../../.prettierignore",
"lint": "npx nx lint",
"pretest-eslint-base": "tsc -b tsconfig.build.json",
Expand Down Expand Up @@ -79,12 +77,5 @@
},
"publishConfig": {
"access": "public"
},
"typesVersions": {
"<3.8": {
"*": [
"_ts3.4/*"
]
}
}
}
7 changes: 0 additions & 7 deletions packages/scope-manager/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,5 @@
"funding": {
"type": "opencollective",
"url": "https://opencollective.com/typescript-eslint"
},
"typesVersions": {
"<4.7": {
"*": [
"_ts4.3/*"
]
}
}
}
9 changes: 2 additions & 7 deletions packages/scope-manager/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,11 @@
"targets": {
"build": {
"executor": "nx:run-commands",
"outputs": ["{projectRoot}/dist", "{projectRoot}/_ts4.3"],
"outputs": ["{projectRoot}/dist"],
"options": {
"parallel": false,
"cwd": "packages/scope-manager",
"commands": [
"rimraf _ts4.3",
"tsc -b tsconfig.build.json",
"downlevel-dts dist _ts4.3/dist --to=4.3"
]
"commands": ["tsc -b tsconfig.build.json"]
}
},
"clean": {
Expand All @@ -26,7 +22,6 @@
"commands": [
"tsc -b tsconfig.build.json --clean",
"rimraf dist",
"rimraf _ts4.3",
"rimraf coverage"
]
}
Expand Down
12 changes: 1 addition & 11 deletions packages/type-utils/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
"files": [
"dist",
"!*.tsbuildinfo",
"_ts4.3",
"package.json",
"README.md",
"LICENSE"
Expand Down Expand Up @@ -38,9 +37,8 @@
],
"scripts": {
"build": "tsc -b tsconfig.build.json",
"postbuild": "downlevel-dts dist _ts4.3/dist --to=4.3",
"clean": "tsc -b tsconfig.build.json --clean",
"postclean": "rimraf dist/ _ts4.3/ coverage/",
"postclean": "rimraf dist/ coverage/",
"format": "prettier --write \"./**/*.{ts,mts,cts,tsx,js,mjs,cjs,jsx,json,md,css}\" --ignore-path ../../.prettierignore",
"lint": "npx nx lint",
"test": "vitest --run --config=$INIT_CWD/vitest.config.mts",
Expand All @@ -60,7 +58,6 @@
"@typescript-eslint/parser": "8.29.1",
"@vitest/coverage-v8": "^3.1.1",
"ajv": "^6.12.6",
"downlevel-dts": "*",
"prettier": "^3.2.5",
"rimraf": "*",
"typescript": "*",
Expand All @@ -69,12 +66,5 @@
"funding": {
"type": "opencollective",
"url": "https://opencollective.com/typescript-eslint"
},
"typesVersions": {
"<4.7": {
"*": [
"_ts4.3/*"
]
}
}
}
12 changes: 1 addition & 11 deletions packages/types/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
"files": [
"dist",
"!*.tsbuildinfo",
"_ts4.3",
"package.json",
"README.md",
"LICENSE"
Expand Down Expand Up @@ -40,9 +39,8 @@
"scripts": {
"copy-ast-spec": "tsx ./tools/copy-ast-spec.mts",
"build": "tsc -b tsconfig.build.json",
"postbuild": "downlevel-dts dist _ts4.3/dist --to=4.3",
"clean": "tsc -b tsconfig.build.json --clean",
"postclean": "rimraf dist && rimraf src/generated && rimraf _ts3.4 && rimraf _ts4.3 && rimraf coverage",
"postclean": "rimraf dist/ src/generated/ coverage/",
"format": "prettier --write \"./**/*.{ts,mts,cts,tsx,js,mjs,cjs,jsx,json,md,css}\" --ignore-path ../../.prettierignore",
"generate-lib": "npx nx run scope-manager:generate-lib",
"lint": "npx nx lint",
Expand All @@ -68,7 +66,6 @@
}
},
"devDependencies": {
"downlevel-dts": "*",
"prettier": "^3.2.5",
"rimraf": "*",
"tsx": "*",
Expand All @@ -77,12 +74,5 @@
"funding": {
"type": "opencollective",
"url": "https://opencollective.com/typescript-eslint"
},
"typesVersions": {
"<4.7": {
"*": [
"_ts4.3/*"
]
}
}
}
12 changes: 1 addition & 11 deletions packages/typescript-eslint/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
"files": [
"dist",
"!*.tsbuildinfo",
"_ts4.3",
"README.md",
"LICENSE"
],
Expand Down Expand Up @@ -44,9 +43,8 @@
],
"scripts": {
"build": "tsc -b tsconfig.build.json",
"postbuild": "downlevel-dts dist _ts4.3/dist --to=4.3",
"clean": "tsc -b tsconfig.build.json --clean",
"postclean": "rimraf dist/ _ts4.3/ coverage/",
"postclean": "rimraf dist/ coverage/",
"format": "prettier --write \"./**/*.{ts,mts,cts,tsx,js,mjs,cjs,jsx,json,md,css}\" --ignore-path ../../.prettierignore",
"lint": "nx lint",
"test": "vitest --run --config=$INIT_CWD/vitest.config.mts",
Expand All @@ -63,7 +61,6 @@
},
"devDependencies": {
"@vitest/coverage-v8": "^3.1.1",
"downlevel-dts": "*",
"prettier": "^3.2.5",
"rimraf": "*",
"typescript": "*",
Expand All @@ -72,12 +69,5 @@
"funding": {
"type": "opencollective",
"url": "https://opencollective.com/typescript-eslint"
},
"typesVersions": {
"<4.7": {
"*": [
"_ts4.3/*"
]
}
}
}
11 changes: 1 addition & 10 deletions packages/typescript-estree/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
"files": [
"dist",
"!*.tsbuildinfo",
"_ts4.3",
"README.md",
"LICENSE"
],
Expand Down Expand Up @@ -46,9 +45,8 @@
],
"scripts": {
"build": "tsc -b tsconfig.build.json",
"postbuild": "downlevel-dts dist _ts4.3/dist --to=4.3",
"clean": "tsc -b tsconfig.build.json --clean",
"postclean": "rimraf dist && rimraf _ts4.3 && rimraf coverage",
"postclean": "rimraf dist/ coverage/",
"format": "prettier --write \"./**/*.{ts,mts,cts,tsx,js,mjs,cjs,jsx,json,md,css}\" --ignore-path ../../.prettierignore",
"lint": "npx nx lint",
"test": "jest --runInBand --verbose",
Expand Down Expand Up @@ -79,12 +77,5 @@
"funding": {
"type": "opencollective",
"url": "https://opencollective.com/typescript-eslint"
},
"typesVersions": {
"<4.7": {
"*": [
"_ts4.3/*"
]
}
}
}
11 changes: 1 addition & 10 deletions packages/utils/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
"files": [
"dist",
"!*.tsbuildinfo",
"_ts4.3",
"package.json",
"README.md",
"LICENSE"
Expand Down Expand Up @@ -55,9 +54,8 @@
],
"scripts": {
"build": "tsc -b tsconfig.build.json",
"postbuild": "downlevel-dts dist _ts4.3/dist --to=4.3",
"clean": "tsc -b tsconfig.build.json --clean",
"postclean": "rimraf dist/ _ts4.3/ coverage/",
"postclean": "rimraf dist/ coverage/",
"format": "prettier --write \"./**/*.{ts,mts,cts,tsx,js,mjs,cjs,jsx,json,md,css}\" --ignore-path ../../.prettierignore",
"lint": "npx nx lint",
"test": "vitest --run --config=$INIT_CWD/vitest.config.mts",
Expand All @@ -84,12 +82,5 @@
"funding": {
"type": "opencollective",
"url": "https://opencollective.com/typescript-eslint"
},
"typesVersions": {
"<4.7": {
"*": [
"_ts4.3/*"
]
}
}
}
12 changes: 1 addition & 11 deletions packages/visitor-keys/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
"files": [
"dist",
"!*.tsbuildinfo",
"_ts4.3",
"package.json",
"README.md",
"LICENSE"
Expand Down Expand Up @@ -39,9 +38,8 @@
],
"scripts": {
"build": "tsc -b tsconfig.build.json",
"postbuild": "downlevel-dts dist _ts4.3/dist --to=4.3",
"clean": "tsc -b tsconfig.build.json --clean",
"postclean": "rimraf dist/ _ts4.3/ coverage/",
"postclean": "rimraf dist/ coverage/",
"format": "prettier --write \"./**/*.{ts,mts,cts,tsx,js,mjs,cjs,jsx,json,md,css}\" --ignore-path ../../.prettierignore",
"lint": "npx nx lint",
"test": "vitest --run --config=$INIT_CWD/vitest.config.mts",
Expand All @@ -53,7 +51,6 @@
},
"devDependencies": {
"@vitest/coverage-v8": "^3.1.1",
"downlevel-dts": "*",
"prettier": "^3.2.5",
"rimraf": "*",
"typescript": "*",
Expand All @@ -62,12 +59,5 @@
"funding": {
"type": "opencollective",
"url": "https://opencollective.com/typescript-eslint"
},
"typesVersions": {
"<4.7": {
"*": [
"_ts4.3/*"
]
}
}
}
Loading
Loading