feat(eslint-plugin): [only-throw-error] add option `allowRethrowing` #11075

kirkwaiblinger · 2025-04-15T00:12:44Z

PR Checklist

Addresses an existing open issue: fixes Enhancement: [only-throw-error] allow re-throwing a caught error #10376
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

There's some doubt over whether a captured catch variable should be considered a rethrow... For example, is this a rethrow?

try {
   // ...
} catch (e) {
   setTimeout(() => { throw e; }, 0);
}

For now, I've implemented it that yes, that's a rethrow, but we could also demand that rethrows must occur within the same function scope as they're caught. This would "false positive" on synchronously executed functions, though, like

try {
   // ...
} catch (e) {
   [1, 2, 3].foreach(x => { if (x % 2 === 0) throw e; });
}

IMO, calling that a rethrow is really a stretch, so I'm gently in favor of banning captured variable rethrows, but I could be convinced either way.

Also included some minor refactoring to use common utilities for parsing .then()/.catch() calls.

typescript-eslint · 2025-04-15T00:12:48Z

Thanks for the PR, @kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2025-04-15T00:13:04Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`786c589`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6818d93a1f8fb800086ac4bd
😎 Deploy Preview	https://deploy-preview-11075--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 98 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

packages/eslint-plugin/package.json

nx-cloud · 2025-04-15T00:13:36Z

View your CI Pipeline Execution ↗ for commit 786c589.

Command	Status	Duration	Result
`nx typecheck ast-spec`	✅ Succeeded	3s	View ↗
`nx run-many --target=build --exclude website --...`	✅ Succeeded	50s	View ↗
`nx run-many --target=clean`	✅ Succeeded	10s	View ↗

☁️ Nx Cloud last updated this comment at 2025-05-05 16:09:24 UTC

codecov · 2025-04-15T01:48:46Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.93%. Comparing base (cc2d6ec) to head (786c589).
Report is 17 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #11075      +/-   ##
==========================================
+ Coverage   90.83%   90.93%   +0.09%     
==========================================
  Files         497      499       +2     
  Lines       50279    50789     +510     
  Branches     8297     8368      +71     
==========================================
+ Hits        45672    46183     +511     
+ Misses       4592     4591       -1     
  Partials       15       15

Flag	Coverage Δ
unittest	`90.93% <100.00%> (+0.09%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...es/eslint-plugin/src/rules/no-floating-promises.ts	`98.37% <100.00%> (-0.06%)`	⬇️
...ckages/eslint-plugin/src/rules/only-throw-error.ts	`100.00% <100.00%> (ø)`
packages/eslint-plugin/src/util/promiseUtils.ts	`100.00% <100.00%> (ø)`

... and 12 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JoshuaKGoldberg

Really nifty stuff! I like the extraction+reuse for Promise detection. Left a few comments, nothing close to blocking IMO. 🔥

packages/eslint-plugin/docs/rules/only-throw-error.mdx

JoshuaKGoldberg · 2025-05-02T18:11:05Z

packages/eslint-plugin/docs/rules/only-throw-error.mdx

+   *
+   * @default false
+   */
+  allowRethrowing?: boolean;


[Docs] The options mentions in this page don't explain why any of the options exist. I suppose that's existing/separate docs work for the other ones. But do you think it'd be reasonable to at least mention allowRethrowing in this PR?

If you'd rather them all tackled together as a followup, I wouldn't block.

packages/eslint-plugin/src/rules/only-throw-error.ts

Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>

JoshuaKGoldberg · 2025-05-05T15:27:38Z

.vscode/extensions.json

@@ -6,7 +6,8 @@
      "esbenp.prettier-vscode",
      "streetsidesoftware.code-spell-checker",
      "tlent.jest-snapshot-language-support",
-      "mrmlnc.vscode-json5"
+      "mrmlnc.vscode-json5",
+      "unifiedjs.vscode-mdx"


I removed this just to be able to merge before the release today - but I wouldn't be against the extension in general

@kirkwaiblinger

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.31.0 | 8.32.0 | | npm | @typescript-eslint/parser | 8.31.0 | 8.32.0 | ## [v8.32.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8320-2025-05-05) ##### 🚀 Features - **eslint-plugin:** \[only-throw-error] add option `allowRethrowing` ([#11075](typescript-eslint/typescript-eslint#11075)) - **eslint-plugin:** \[no-unnecessary-type-conversion] add rule ([#10182](typescript-eslint/typescript-eslint#10182)) ##### 🩹 Fixes - **eslint-plugin:** \[prefer-nullish-coalescing] fix parenthesization bug in suggestion ([#11098](typescript-eslint/typescript-eslint#11098)) - **eslint-plugin:** \[unified-signatures] exempt `this` from optional parameter overload check ([#11005](typescript-eslint/typescript-eslint#11005)) - **eslint-plugin:** \[no-unnecessary-type-parameters] should parenthesize type in suggestion fixer if necessary ([#10907](typescript-eslint/typescript-eslint#10907)) ##### ❤️ Thank You - Andy Edwards - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) - mdm317 - Sasha Kondrashov - Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.31.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8311-2025-04-28) ##### 🩹 Fixes - **eslint-plugin:** \[no-unnecessary-condition] downgrade fix to suggestion ([#11081](typescript-eslint/typescript-eslint#11081)) ##### ❤️ Thank You - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

@kirkwaiblinger

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.31.0 | 8.32.0 | | npm | @typescript-eslint/parser | 8.31.0 | 8.32.0 | ## [v8.32.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8320-2025-05-05) ##### 🚀 Features - **eslint-plugin:** \[only-throw-error] add option `allowRethrowing` ([#11075](typescript-eslint/typescript-eslint#11075)) - **eslint-plugin:** \[no-unnecessary-type-conversion] add rule ([#10182](typescript-eslint/typescript-eslint#10182)) ##### 🩹 Fixes - **eslint-plugin:** \[prefer-nullish-coalescing] fix parenthesization bug in suggestion ([#11098](typescript-eslint/typescript-eslint#11098)) - **eslint-plugin:** \[unified-signatures] exempt `this` from optional parameter overload check ([#11005](typescript-eslint/typescript-eslint#11005)) - **eslint-plugin:** \[no-unnecessary-type-parameters] should parenthesize type in suggestion fixer if necessary ([#10907](typescript-eslint/typescript-eslint#10907)) ##### ❤️ Thank You - Andy Edwards - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) - mdm317 - Sasha Kondrashov - Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.31.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8311-2025-04-28) ##### 🩹 Fixes - **eslint-plugin:** \[no-unnecessary-condition] downgrade fix to suggestion ([#11081](typescript-eslint/typescript-eslint#11081)) ##### ❤️ Thank You - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

@kirkwaiblinger

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.31.0 | 8.32.0 | | npm | @typescript-eslint/parser | 8.31.0 | 8.32.0 | ## [v8.32.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8320-2025-05-05) ##### 🚀 Features - **eslint-plugin:** \[only-throw-error] add option `allowRethrowing` ([#11075](typescript-eslint/typescript-eslint#11075)) - **eslint-plugin:** \[no-unnecessary-type-conversion] add rule ([#10182](typescript-eslint/typescript-eslint#10182)) ##### 🩹 Fixes - **eslint-plugin:** \[prefer-nullish-coalescing] fix parenthesization bug in suggestion ([#11098](typescript-eslint/typescript-eslint#11098)) - **eslint-plugin:** \[unified-signatures] exempt `this` from optional parameter overload check ([#11005](typescript-eslint/typescript-eslint#11005)) - **eslint-plugin:** \[no-unnecessary-type-parameters] should parenthesize type in suggestion fixer if necessary ([#10907](typescript-eslint/typescript-eslint#10907)) ##### ❤️ Thank You - Andy Edwards - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) - mdm317 - Sasha Kondrashov - Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.31.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8311-2025-04-28) ##### 🩹 Fixes - **eslint-plugin:** \[no-unnecessary-condition] downgrade fix to suggestion ([#11081](typescript-eslint/typescript-eslint#11081)) ##### ❤️ Thank You - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

kirkwaiblinger and others added 3 commits December 7, 2024 16:14

wip

2903ff5

Merge branch 'main' into only-throw-error-rethrow

26a6b9e

progress

7d4332c

kirkwaiblinger commented Apr 15, 2025

View reviewed changes

packages/eslint-plugin/package.json Outdated Show resolved Hide resolved

kirkwaiblinger added 2 commits April 14, 2025 18:21

comment

c3cfb66

snapshots

0b13b1d

kirkwaiblinger added 7 commits May 1, 2025 08:09

Merge branch 'main' into only-throw-error-rethrow

fc852e6

cov

29f2160

cov2

a472855

docs

4febd74

revert unrelated change

22b249a

more comments

e2da1c9

fixup

dd71c12

kirkwaiblinger marked this pull request as ready for review May 1, 2025 16:56

JoshuaKGoldberg previously approved these changes May 2, 2025

View reviewed changes

JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label May 2, 2025

Update packages/eslint-plugin/docs/rules/only-throw-error.mdx

e583c08

Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>

kirkwaiblinger dismissed JoshuaKGoldberg’s stale review via e583c08 May 5, 2025 05:17

simplify type assertion

3237b22

kirkwaiblinger requested a review from JoshuaKGoldberg May 5, 2025 05:27

github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label May 5, 2025

JoshuaKGoldberg reviewed May 5, 2025

View reviewed changes

fix lint and an unrelated change

786c589

JoshuaKGoldberg merged commit 29ea555 into typescript-eslint:main May 5, 2025
53 checks passed

kirkwaiblinger deleted the only-throw-error-rethrow branch May 5, 2025 15:54

kirkwaiblinger mentioned this pull request May 5, 2025

Docs: [only-throw-error] give explanation of options #11173

Open

2 tasks

github-actions bot locked as resolved and limited conversation to collaborators May 13, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(eslint-plugin): [only-throw-error] add option `allowRethrowing` #11075

feat(eslint-plugin): [only-throw-error] add option `allowRethrowing` #11075

kirkwaiblinger commented Apr 15, 2025 •

edited

Loading

typescript-eslint bot commented Apr 15, 2025

netlify bot commented Apr 15, 2025 •

edited

Loading

nx-cloud bot commented Apr 15, 2025 •

edited

Loading

codecov bot commented Apr 15, 2025 •

edited

Loading

JoshuaKGoldberg left a comment

JoshuaKGoldberg May 2, 2025

JoshuaKGoldberg May 5, 2025

JoshuaKGoldberg May 5, 2025

feat(eslint-plugin): [only-throw-error] add option allowRethrowing #11075

feat(eslint-plugin): [only-throw-error] add option allowRethrowing #11075

Conversation

kirkwaiblinger commented Apr 15, 2025 • edited Loading

PR Checklist

Overview

typescript-eslint bot commented Apr 15, 2025

netlify bot commented Apr 15, 2025 • edited Loading

✅ Deploy Preview for typescript-eslint ready!

nx-cloud bot commented Apr 15, 2025 • edited Loading

codecov bot commented Apr 15, 2025 • edited Loading

Codecov Report

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

JoshuaKGoldberg May 2, 2025

Choose a reason for hiding this comment

JoshuaKGoldberg May 5, 2025

Choose a reason for hiding this comment

JoshuaKGoldberg May 5, 2025

Choose a reason for hiding this comment

feat(eslint-plugin): [only-throw-error] add option `allowRethrowing` #11075

feat(eslint-plugin): [only-throw-error] add option `allowRethrowing` #11075

kirkwaiblinger commented Apr 15, 2025 •

edited

Loading

netlify bot commented Apr 15, 2025 •

edited

Loading

nx-cloud bot commented Apr 15, 2025 •

edited

Loading

codecov bot commented Apr 15, 2025 •

edited

Loading