Skip to content

chore(typescript-estree): remove dead failure path #11556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 1, 2025
Merged

chore(typescript-estree): remove dead failure path #11556

merged 2 commits into from
Sep 1, 2025
+2 −8

Conversation

kirkwaiblinger
Copy link
Member

PR Checklist

Overview

useProvidedPrograms() throws instead of returning undefined if it fails

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Sep 1, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit aa6c560
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/68b5996fdab0db000866d24b
😎 Deploy Preview https://deploy-preview-11556--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 80 (🔴 down 17 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Sep 1, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit aa6c560

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 14s View ↗
nx run-many -t lint ✅ Succeeded 3m 15s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 12s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 20s View ↗
nx run integration-tests:test ✅ Succeeded 6s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 9s View ↗
nx run types:build ✅ Succeeded 5s View ↗
nx run generate-configs ✅ Succeeded 6s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-09-01 13:14:24 UTC

@kirkwaiblinger kirkwaiblinger enabled auto-merge (squash) September 1, 2025 02:51
@codecov Codecov
Copy link

codecov bot commented Sep 1, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.84%. Comparing base (ee3efa7) to head (aa6c560).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #11556   +/-   ##
=======================================
  Coverage   90.84%   90.84%           
=======================================
  Files         505      505           
  Lines       51167    51167           
  Branches     8422     8422           
=======================================
  Hits        46485    46485           
  Misses       4668     4668           
  Partials       14       14
Flag Coverage Δ
unittest 90.84% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...t-estree/src/create-program/useProvidedPrograms.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Sep 1, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow nice! Such an important code path, it's good to see it get simpler.

@kirkwaiblinger kirkwaiblinger enabled auto-merge (squash) September 1, 2025 13:02
@kirkwaiblinger kirkwaiblinger merged commit dce5360 into typescript-eslint:main Sep 1, 2025
60 of 61 checks passed
@kirkwaiblinger kirkwaiblinger deleted the remove-dead-code branch September 1, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kirkwaiblinger @JoshuaKGoldberg @bradzacher