Skip to content

chore(typescript-estree): remove dead failure path #11556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 1, 2025
+2 −8
Merged

chore(typescript-estree): remove dead failure path #11556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3aa654f
remove dead failure path
kirkwaiblinger Sep 1, 2025
aa6c560
Merge branch 'main' into remove-dead-code
kirkwaiblinger Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/typescript-estree/src/create-program/useProvidedPrograms.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const log = debug(
export function useProvidedPrograms(
programInstances: Iterable<ts.Program>,
parseSettings: ParseSettings,
): ASTAndDefiniteProgram | undefined {
): ASTAndDefiniteProgram {
log(
'Retrieving ast for %s from provided program instance(s)',
parseSettings.filePath,
Expand Down
8 changes: 1 addition & 7 deletions packages/typescript-estree/src/parser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,13 +68,7 @@ function getProgramAndAST(
}

if (parseSettings.programs) {
const fromProvidedPrograms = useProvidedPrograms(
parseSettings.programs,
parseSettings,
);
if (fromProvidedPrograms) {
return fromProvidedPrograms;
}
return useProvidedPrograms(parseSettings.programs, parseSettings);
}

// no need to waste time creating a program as the caller didn't want parser services
Expand Down
Loading