Skip to content

docs(eslint-plugin): added missing TSLint 5.20 rules to ROADMAP.md #1609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Feb 15, 2020

We can be sure this is the last of the core rules to be added, because TSLint is deprecated now 😄.

Fixes #1034.
Edit: also fixes #1627.

We can be sure this is the last of the core rules to be added, because TSLint is deprecated now 😄.
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few changes, otherwise lgtm, thanks!

@bradzacher bradzacher added the documentation Documentation ("docs") that needs adding/updating label Feb 19, 2020
@codecov
Copy link

codecov bot commented Feb 22, 2020

Codecov Report

Merging #1609 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1609      +/-   ##
==========================================
- Coverage   95.54%   95.52%   -0.02%     
==========================================
  Files         142      142              
  Lines        6583     6621      +38     
  Branches     1883     1895      +12     
==========================================
+ Hits         6290     6325      +35     
  Misses        106      106              
- Partials      187      190       +3
Impacted Files Coverage Δ
packages/eslint-plugin/src/util/astUtils.ts 80.55% <0%> (-3.82%) ⬇️
packages/eslint-plugin/src/rules/return-await.ts 95.71% <0%> (-0.21%) ⬇️
...es/eslint-plugin/src/rules/no-floating-promises.ts 100% <0%> (ø) ⬆️
packages/eslint-plugin/src/rules/typedef.ts 97.05% <0%> (+0.56%) ⬆️

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bradzacher bradzacher merged commit be3e23f into typescript-eslint:master Feb 23, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
@JoshuaKGoldberg JoshuaKGoldberg deleted the roadmap-tslint-5-20 branch November 17, 2021 07:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ROADMAP with no-reference-import TSLint equivalent TSLint 5.20 rules missing from ROADMAP.md
2 participants