-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
docs(eslint-plugin): added missing TSLint 5.20 rules to ROADMAP.md #1609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(eslint-plugin): added missing TSLint 5.20 rules to ROADMAP.md #1609
Conversation
We can be sure this is the last of the core rules to be added, because TSLint is deprecated now 😄.
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few changes, otherwise lgtm, thanks!
Codecov Report
@@ Coverage Diff @@
## master #1609 +/- ##
==========================================
- Coverage 95.54% 95.52% -0.02%
==========================================
Files 142 142
Lines 6583 6621 +38
Branches 1883 1895 +12
==========================================
+ Hits 6290 6325 +35
Misses 106 106
- Partials 187 190 +3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
We can be sure this is the last of the core rules to be added, because TSLint is deprecated now 😄.
Fixes #1034.
Edit: also fixes #1627.