Skip to content

docs(eslint-plugin): update link to deprecation rule in roadmap #1611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 18, 2020
Merged

docs(eslint-plugin): update link to deprecation rule in roadmap #1611

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
145b884
docs(roadmap): update deprecation rule
gund Feb 17, 2020
5d7ae22
docs(roadmap): add link to deprecation plugin repo
gund Feb 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/eslint-plugin/ROADMAP.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ It lists all TSLint rules along side rules from the ESLint ecosystem that are th
| TSLint rule | | ESLint rule |
| ---------------------------- | :-: | -------------------------------------------------- |
| [`cyclomatic-complexity`] | 🌟 | [`complexity`][complexity] |
| [`deprecation`] | 🌓 | [`import/no-deprecated`] <sup>[1]</sup> |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to add this link to the bottom section.

Copy link
Contributor Author

@gund gund Feb 17, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it does not apply anymore, since the rule applies not only to imports but to all deprecated references just like the original tslint rule...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add the link to the bottom section so that this line renders as a link

image

Bottom section:
https://github.com/gund/typescript-eslint/blob/patch-1/packages/eslint-plugin/ROADMAP.md#L677-L688

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see, will update

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

| [`deprecation`] | 🔌 | [`deprecation/deprecation`] |
| [`eofline`] | 🌟 | [`eol-last`][eol-last] |
| [`indent`] | ✅ | [`@typescript-eslint/indent`] or [Prettier] |
| [`linebreak-style`] | 🌟 | [`linebreak-style`][linebreak-style] or [Prettier] |
Expand Down Expand Up @@ -686,3 +686,4 @@ Relevant plugins: [`chai-expect-keywords`](https://github.com/gavinaiken/eslint-
[`jest/no-focused-tests`]: https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/no-focused-tests.md
[`jsx-a11y/heading-has-content`]: https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/heading-has-content.md
[`lodash/chaining`]: https://github.com/wix/eslint-plugin-lodash/blob/master/docs/rules/chaining.md
[`deprecation/deprecation`]: https://github.com/gund/eslint-plugin-deprecation