Skip to content

feat(eslint-plugin): added new rule promise-function-async #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

Adds the equivalent of TSLint's promise-function-async rule.

Adds the equivalent of TSLint's `promise-function-async` rule.
@codecov
Copy link

codecov bot commented Feb 3, 2019

Codecov Report

Merging #194 into master will decrease coverage by 0.07%.
The diff coverage is 92.1%.

@@            Coverage Diff             @@
##           master     #194      +/-   ##
==========================================
- Coverage   96.85%   96.78%   -0.08%     
==========================================
  Files          53       55       +2     
  Lines        2478     2516      +38     
  Branches      372      372              
==========================================
+ Hits         2400     2435      +35     
- Misses         39       42       +3     
  Partials       39       39
Impacted Files Coverage Δ
.../eslint-plugin/lib/rules/promise-function-async.js 100% <100%> (ø)
packages/eslint-plugin/lib/utils/types.js 78.57% <78.57%> (ø)

@JoshuaKGoldberg JoshuaKGoldberg changed the title feat: (eslint-plugin) added new rule await-promise feat: (eslint-plugin) added new rule promise-function-async Feb 3, 2019
@armano2 armano2 changed the title feat: (eslint-plugin) added new rule promise-function-async feat(eslint-plugin): added new rule promise-function-async Feb 3, 2019
@armano2 armano2 added the enhancement: new plugin rule New rule request for eslint-plugin label Feb 3, 2019
bradzacher
bradzacher previously approved these changes Feb 5, 2019
JamesHenry
JamesHenry previously approved these changes Feb 6, 2019
@JamesHenry
Copy link
Member

Apologies for the conflicts, we decided to remove the counts from the ROADMAP here: #225

They are too awkward to maintain manually, so this is the last time you will have to deal with syncing that up!

@bradzacher bradzacher dismissed stale reviews from JamesHenry and themself via 131a158 February 7, 2019 03:47
@JamesHenry JamesHenry merged commit 5f3aec9 into typescript-eslint:master Feb 7, 2019
@JoshuaKGoldberg JoshuaKGoldberg deleted the typescript-eslint-promise-function-async branch February 7, 2019 14:28
kaicataldo pushed a commit to kaicataldo/typescript-eslint that referenced this pull request Aug 27, 2019
This package now depends directly on typescript-eslint-parser, so no need to do that.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement: new plugin rule New rule request for eslint-plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants