-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat(eslint-plugin): added new rule promise-function-async #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JamesHenry
merged 13 commits into
typescript-eslint:master
from
JoshuaKGoldberg:typescript-eslint-promise-function-async
Feb 7, 2019
Merged
feat(eslint-plugin): added new rule promise-function-async #194
JamesHenry
merged 13 commits into
typescript-eslint:master
from
JoshuaKGoldberg:typescript-eslint-promise-function-async
Feb 7, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the equivalent of TSLint's `promise-function-async` rule.
Codecov Report
@@ Coverage Diff @@
## master #194 +/- ##
==========================================
- Coverage 96.85% 96.78% -0.08%
==========================================
Files 53 55 +2
Lines 2478 2516 +38
Branches 372 372
==========================================
+ Hits 2400 2435 +35
- Misses 39 42 +3
Partials 39 39
|
bradzacher
reviewed
Feb 4, 2019
Co-Authored-By: JoshuaKGoldberg <joshuakgoldberg@outlook.com>
bradzacher
previously approved these changes
Feb 5, 2019
JamesHenry
previously approved these changes
Feb 6, 2019
Apologies for the conflicts, we decided to remove the counts from the ROADMAP here: #225 They are too awkward to maintain manually, so this is the last time you will have to deal with syncing that up! |
bradzacher
approved these changes
Feb 7, 2019
JamesHenry
approved these changes
Feb 7, 2019
kaicataldo
pushed a commit
to kaicataldo/typescript-eslint
that referenced
this pull request
Aug 27, 2019
This package now depends directly on typescript-eslint-parser, so no need to do that.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the equivalent of TSLint's
promise-function-async
rule.