Skip to content

chore: share parser fixtures where applicable for unit tests #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jan 16, 2019

Conversation

JamesHenry
Copy link
Member

No description provided.

platinumazure
platinumazure previously approved these changes Jan 15, 2019
@JamesHenry
Copy link
Member Author

Hmm runs fine locally, but it doesn't seem to like the relative path traversal on Travis

@armano2
Copy link
Collaborator

armano2 commented Jan 15, 2019

Q: why we just don't make private package for tests cases?

it will solve issue with this, and it will make sure that we can reuse across all projects?

node_modules/typescript-eslint-fixtures/fixtures

@JamesHenry
Copy link
Member Author

Yeah was thinking along the same lines eventually, but still very confused why this doesn't already work!

I'll update it to be a package

@JamesHenry JamesHenry force-pushed the tests branch 2 times, most recently from a423b7a to f7dc17b Compare January 15, 2019 20:50
@JamesHenry
Copy link
Member Author

@armano2 It actually hasn't helped :/ I can't look into this any more today, anybody else is welcome to take a look, otherwise I will pick this up again tomorrow

@JamesHenry
Copy link
Member Author

@armano2 I am working on this - did you not see my commit?

@JamesHenry
Copy link
Member Author

Your commit doesn't conflict with mine, so all good - but I have a major push coming shortly 👍

@armano2
Copy link
Collaborator

armano2 commented Jan 16, 2019

**** sorry didn't notice it

@JamesHenry
Copy link
Member Author

I've fixed the issues by getting rid of all the old shelljs stuff

@codecov
Copy link

codecov bot commented Jan 16, 2019

Codecov Report

Merging #26 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
+ Coverage   94.16%   94.16%   +<.01%     
==========================================
  Files          13       13              
  Lines        1697     1698       +1     
  Branches      325      325              
==========================================
+ Hits         1598     1599       +1     
  Misses         60       60              
  Partials       39       39
Impacted Files Coverage Δ
...kages/typescript-eslint-parser/tools/test-utils.js 88.88% <100%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed7192c...d02f817. Read the comment docs.

@JamesHenry JamesHenry merged commit 58c4d1c into master Jan 16, 2019
@JamesHenry JamesHenry deleted the tests branch January 16, 2019 02:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants