-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
chore: share parser fixtures where applicable for unit tests #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hmm runs fine locally, but it doesn't seem to like the relative path traversal on Travis |
Q: why we just don't make private package for tests cases? it will solve issue with this, and it will make sure that we can reuse across all projects?
|
Yeah was thinking along the same lines eventually, but still very confused why this doesn't already work! I'll update it to be a package |
a423b7a
to
f7dc17b
Compare
@armano2 It actually hasn't helped :/ I can't look into this any more today, anybody else is welcome to take a look, otherwise I will pick this up again tomorrow |
@armano2 I am working on this - did you not see my commit? |
Your commit doesn't conflict with mine, so all good - but I have a major push coming shortly 👍 |
**** sorry didn't notice it |
I've fixed the issues by getting rid of all the old shelljs stuff |
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
==========================================
+ Coverage 94.16% 94.16% +<.01%
==========================================
Files 13 13
Lines 1697 1698 +1
Branches 325 325
==========================================
+ Hits 1598 1599 +1
Misses 60 60
Partials 39 39
Continue to review full report at Codecov.
|
No description provided.