-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
chore(eslint-plugin): remove support for eslint 5 #2683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(eslint-plugin): remove support for eslint 5 #2683
Conversation
Thanks for the PR, @thomasmichaelwallace! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
Thanks for doing this! I didn't label it as such, but it is a breaking change - any change in the supported dependencies is a breaking change (even if people should have upgraded their deps by now). |
No worries - I did suspect as much. Feel free to @thomasmichaelwallace me when the time comes for v5, I'd be happy to tackle any issues updating the branch for merge. It'd be awesome if you could label the PRs hacktoberfest-accepted in the interim. (Sorry to ask, it's annoying they put this on the maintainers; if it's a hassle, it's not a problem.) |
Unfortunately with eslint v8 they hid all of their utils - so we can't leverage them - so we're stuck with the changes from #2917 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this! we can finally merge this in :)
Resolves #2465
As far as I understood the issue, you don't think this is a breaking change (what with v5 being very old).
Following the issue I compared against eslint 6.8 (latest) to see what messageIds weren't set then, so as to avoid regressing #2451.