Skip to content

refactor(eslint-plugin): [no-floating-promises] update code to use AST instead of ts nodes #3195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2021
Merged

refactor(eslint-plugin): [no-floating-promises] update code to use AST instead of ts nodes #3195

merged 1 commit into from
Mar 18, 2021

Conversation

armano2
Copy link
Collaborator

@armano2 armano2 commented Mar 17, 2021

No description provided.

@armano2 armano2 added the package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin label Mar 17, 2021
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #3195 (1d24944) into master (9ed3c50) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3195      +/-   ##
==========================================
- Coverage   92.91%   92.91%   -0.01%     
==========================================
  Files         316      316              
  Lines       10808    10805       -3     
  Branches     3056     3055       -1     
==========================================
- Hits        10042    10039       -3     
  Misses        342      342              
  Partials      424      424
Flag Coverage Δ
unittest 92.91% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...es/eslint-plugin/src/rules/no-floating-promises.ts 100.00% <100.00%> (ø)

@bradzacher bradzacher added the refactor PRs that refactor code only label Mar 18, 2021
bradzacher
bradzacher approved these changes Mar 18, 2021
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bradzacher bradzacher merged commit 56af989 into master Mar 18, 2021
@bradzacher bradzacher deleted the refactor/no-floating-promises branch March 18, 2021 19:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin refactor PRs that refactor code only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@armano2 @bradzacher