Skip to content

chore(experimental-utils): remove useless union types ast-utils predicates #3289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MichaelDeBoey
Copy link
Contributor

Comment is a sub-type of Token

export type Token =
| BooleanToken
| Comment
| IdentifierToken
| JSXIdentifierToken
| JSXTextToken
| KeywordToken
| NullToken
| NumericToken
| PunctuatorToken
| RegularExpressionToken
| StringToken
| TemplateToken;

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @MichaelDeBoey!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@MichaelDeBoey MichaelDeBoey force-pushed the update-token-type-in-predicates branch from e9548a4 to 7c3124a Compare April 15, 2021 00:31
@MichaelDeBoey MichaelDeBoey force-pushed the update-token-type-in-predicates branch from fb2cb11 to 2983aeb Compare May 12, 2021 18:32
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this!

@bradzacher bradzacher changed the title refactor(experimental-utils): update token type in ast-utils predicates chore(experimental-utils): remove useless union types ast-utils predicates May 15, 2021
@bradzacher bradzacher added the refactor PRs that refactor code only label May 15, 2021
@bradzacher bradzacher merged commit c80b5f2 into typescript-eslint:master May 15, 2021
@MichaelDeBoey
Copy link
Contributor Author

Always happy to help! 👊

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
refactor PRs that refactor code only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants