Skip to content

feat(typescript-estree): support private fields in-in syntax #4075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 12, 2021
Merged

feat(typescript-estree): support private fields in-in syntax #4075

merged 6 commits into from
Nov 12, 2021

Conversation

sosukesuzuki
Copy link
Contributor

PR Checklist

Overview

Adds support for #bar in foo syntax.(updating types and adding tests)

Based on #4073

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @sosukesuzuki!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@nx-cloud
Copy link

nx-cloud bot commented Oct 30, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit 9161279. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 Node 16.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 16.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-internal
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 14.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 14.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 16.x - nx test @typescript-eslint/parser
#000000 Node 16.x - nx test @typescript-eslint/experimental-utils
#000000 Node 16.x - nx test @typescript-eslint/scope-manager
#000000 Node 12.x - nx test @typescript-eslint/parser
#000000 Node 12.x - nx test @typescript-eslint/experimental-utils
#000000 Node 12.x - nx test @typescript-eslint/scope-manager
#000000 Node 12.x - nx test @typescript-eslint/parser
#000000 Node 12.x - nx test @typescript-eslint/experimental-utils
#000000 Node 12.x - nx test @typescript-eslint/scope-manager
#000000 Node 12.x - nx test @typescript-eslint/visitor-keys
#000000 Node 12.x - nx test @typescript-eslint/typescript-estree

Sent with 💌 from NxCloud.

@sosukesuzuki
Copy link
Contributor Author

I'll fix type errors at tomorrow.

@bradzacher bradzacher mentioned this pull request Nov 11, 2021
Closed
8 tasks
bradzacher
bradzacher reviewed Nov 11, 2021
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just type changes - sweet!

packages/ast-spec/src/base/BinaryExpressionBase.ts Outdated
@@ -1,8 +1,9 @@
import type { PrivateIdentifier } from '../special/PrivateIdentifier/spec';
import type { Expression } from '../unions/Expression';
import type { BaseNode } from './BaseNode';

export interface BinaryExpressionBase extends BaseNode {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at this point we could probably just delete this interface entirely. Each node that extends this already declares its own operator, and with one node now declaring its own left - it's kind of no longer a "shared common base".

@bradzacher bradzacher added the AST PRs and Issues about the AST structure label Nov 11, 2021
@sosukesuzuki sosukesuzuki force-pushed the ts4.5-private-fields-in-in branch from b5ed659 to dac4bab Compare November 11, 2021 09:57
@netlify
Copy link

netlify bot commented Nov 11, 2021 •
edited
Loading

✔️ Deploy Preview for typescript-eslint ready!

🔨 Explore the source changes: 9161279

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/618de78eca110d00082701d2

😎 Browse the preview: https://deploy-preview-4075--typescript-eslint.netlify.app

@codecov
Copy link

codecov bot commented Nov 11, 2021 •
edited
Loading

Codecov Report

Merging #4075 (9161279) into master (ae0fb5a) will decrease coverage by 0.26%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4075      +/-   ##
==========================================
- Coverage   93.35%   93.08%   -0.27%     
==========================================
  Files         152      295     +143     
  Lines        8035    11095    +3060     
  Branches     2579     3232     +653     
==========================================
+ Hits         7501    10328    +2827     
- Misses        180      299     +119     
- Partials      354      468     +114
Flag Coverage Δ
unittest 93.08% <100.00%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lugin/src/rules/no-confusing-non-null-assertion.ts 82.60% <ø> (ø)
...rc/rules/no-unnecessary-boolean-literal-compare.ts 93.50% <ø> (ø)
packages/eslint-plugin/src/rules/prefer-for-of.ts 90.00% <ø> (ø)
...plugin/src/rules/prefer-string-starts-ends-with.ts 97.83% <ø> (ø)
.../eslint-plugin/src/rules/restrict-plus-operands.ts 100.00% <ø> (ø)
...kages/eslint-plugin/src/rules/no-base-to-string.ts 98.48% <100.00%> (+0.02%) ⬆️
packages/scope-manager/src/lib/es2019.ts 100.00% <0.00%> (ø)
packages/scope-manager/src/lib/es2015.core.ts 100.00% <0.00%> (ø)
packages/scope-manager/src/lib/es2020.ts 100.00% <0.00%> (ø)
...cope-manager/src/definition/ClassNameDefinition.ts 100.00% <0.00%> (ø)
... and 139 more

@sosukesuzuki sosukesuzuki force-pushed the ts4.5-private-fields-in-in branch from dac4bab to 9161279 Compare November 12, 2021 04:03
@sosukesuzuki sosukesuzuki marked this pull request as ready for review November 12, 2021 04:35
@sosukesuzuki
Copy link
Contributor Author

@bradzacher Thank you for the review! I've updated!

bradzacher
bradzacher approved these changes Nov 12, 2021
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! thanks for this!

@bradzacher bradzacher merged commit 939d8ea into typescript-eslint:master Nov 12, 2021
This was referenced Nov 16, 2021
Open
Open
Open
Open
Open
Open
Open
This was referenced Nov 23, 2021
Open
Open
Open
This was referenced Nov 26, 2021
Open
Open
Open
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
AST PRs and Issues about the AST structure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sosukesuzuki @bradzacher