Skip to content

feat(typescript-estree): support type-only module specifiers #4076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 12, 2021
Merged

feat(typescript-estree): support type-only module specifiers #4076

merged 7 commits into from
Nov 12, 2021

Conversation

sosukesuzuki
Copy link
Contributor

@sosukesuzuki sosukesuzuki commented Oct 30, 2021 •
edited by bradzacher
Loading

PR Checklist

Overview

Adds support for type-only module specifiers.

Based on #4073

@nx-cloud
Copy link

nx-cloud bot commented Oct 30, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit ed5d3eb. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 16.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 16.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-internal
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 14.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 14.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 16.x - nx test @typescript-eslint/parser
#000000 Node 16.x - nx test @typescript-eslint/experimental-utils
#000000 Node 12.x - nx test @typescript-eslint/parser
#000000 Node 12.x - nx test @typescript-eslint/experimental-utils
#000000 Node 12.x - nx test @typescript-eslint/scope-manager
#000000 Node 12.x - nx test @typescript-eslint/visitor-keys
#000000 Node 12.x - nx test @typescript-eslint/typescript-estree
#000000 Node 16.x - nx test @typescript-eslint/scope-manager
#000000 Node 12.x - nx test @typescript-eslint/parser
#000000 Node 16.x - nx test @typescript-eslint/visitor-keys
#000000 Node 12.x - nx test @typescript-eslint/experimental-utils

Sent with 💌 from NxCloud.

@bradzacher bradzacher added the AST PRs and Issues about the AST structure label Nov 2, 2021
@bradzacher bradzacher mentioned this pull request Nov 2, 2021
Closed
8 tasks
bradzacher
bradzacher reviewed Nov 11, 2021
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ast + parser changes LGTM!

@sosukesuzuki sosukesuzuki force-pushed the ts4.5-type-only-module-specifiers branch from 647456c to 1aee3b1 Compare November 11, 2021 08:57
@netlify
Copy link

netlify bot commented Nov 11, 2021 •
edited
Loading

✔️ Deploy Preview for typescript-eslint ready!

🔨 Explore the source changes: ed5d3eb

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/618e1cfc05e3cd0007a8afa5

😎 Browse the preview: https://deploy-preview-4076--typescript-eslint.netlify.app

@sosukesuzuki sosukesuzuki force-pushed the ts4.5-type-only-module-specifiers branch from e1d01d5 to 6c7507f Compare November 12, 2021 04:31
@codecov
Copy link

codecov bot commented Nov 12, 2021 •
edited
Loading

Codecov Report

Merging #4076 (ed5d3eb) into master (ae0fb5a) will decrease coverage by 0.59%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4076      +/-   ##
==========================================
- Coverage   93.35%   92.75%   -0.60%     
==========================================
  Files         152      334     +182     
  Lines        8035    11510    +3475     
  Branches     2579     3279     +700     
==========================================
+ Hits         7501    10676    +3175     
- Misses        180      362     +182     
- Partials      354      472     +118
Flag Coverage Δ
unittest 92.75% <100.00%> (-0.60%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lugin/src/rules/no-confusing-non-null-assertion.ts 82.60% <ø> (ø)
...rc/rules/no-unnecessary-boolean-literal-compare.ts 93.50% <ø> (ø)
packages/eslint-plugin/src/rules/prefer-for-of.ts 90.00% <ø> (ø)
...plugin/src/rules/prefer-string-starts-ends-with.ts 97.83% <ø> (ø)
.../eslint-plugin/src/rules/restrict-plus-operands.ts 100.00% <ø> (ø)
...kages/eslint-plugin/src/rules/no-base-to-string.ts 98.48% <100.00%> (+0.02%) ⬆️
packages/typescript-estree/src/convert.ts 98.25% <100.00%> (ø)
...ges/scope-manager/src/definition/DefinitionBase.ts 100.00% <0.00%> (ø)
...ackages/scope-manager/src/lib/es2015.collection.ts 100.00% <0.00%> (ø)
packages/scope-manager/src/lib/es2018.ts 100.00% <0.00%> (ø)
... and 179 more

@sosukesuzuki sosukesuzuki force-pushed the ts4.5-type-only-module-specifiers branch from 6c7507f to ed5d3eb Compare November 12, 2021 07:51
@sosukesuzuki sosukesuzuki marked this pull request as ready for review November 12, 2021 08:34
@sosukesuzuki
Copy link
Contributor Author

@bradzacher Ready for review!

bradzacher
bradzacher approved these changes Nov 12, 2021
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for doing all of this!

@bradzacher bradzacher merged commit 77baa92 into typescript-eslint:master Nov 12, 2021
@sosukesuzuki sosukesuzuki deleted the ts4.5-type-only-module-specifiers branch November 12, 2021 19:18
This was referenced Nov 16, 2021
Open
Open
Open
Open
Open
Open
Open
This was referenced Nov 23, 2021
Open
Open
This was referenced Nov 25, 2021
Open
Open
Open
Open
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
AST PRs and Issues about the AST structure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sosukesuzuki @bradzacher