Skip to content

fix(typescript-estree): type-only regression for consumers not yet on TS 4.5 #4272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2021
Merged

fix(typescript-estree): type-only regression for consumers not yet on TS 4.5 #4272

merged 1 commit into from
Dec 7, 2021

Conversation

lonyele
Copy link
Contributor

@lonyele lonyele commented Dec 7, 2021

PR Checklist

Overview

I tested with typesript 4.4 variations and got another error so I added AssertClause aside from mentioned issue's AssertEntry(Maybe I did it with wrong local setting?)
스크린샷 2021-12-07 오후 10 03 02

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @lonyele!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Dec 7, 2021 •
edited
Loading

✔️ Deploy Preview for typescript-eslint ready!

🔨 Explore the source changes: bc45172

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61af62a56546cc000850f42c

😎 Browse the preview: https://deploy-preview-4272--typescript-eslint.netlify.app

@nx-cloud
Copy link

nx-cloud bot commented Dec 7, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit bc45172. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 Node 16.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 16.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-internal
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 14.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 14.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 16.x - nx test @typescript-eslint/parser
#000000 Node 16.x - nx test @typescript-eslint/experimental-utils
#000000 Node 16.x - nx test @typescript-eslint/scope-manager
#000000 Node 16.x - nx test @typescript-eslint/visitor-keys
#000000 Node 16.x - nx test @typescript-eslint/typescript-estree
#000000 Node 12.x - nx test @typescript-eslint/parser
#000000 Node 12.x - nx test @typescript-eslint/parser
#000000 Node 12.x - nx test @typescript-eslint/experimental-utils
#000000 Node 12.x - nx test @typescript-eslint/scope-manager
#000000 Node 12.x - nx test @typescript-eslint/experimental-utils
#000000 Node 12.x - nx test @typescript-eslint/scope-manager

Sent with 💌 from NxCloud.

@codecov
Copy link

codecov bot commented Dec 7, 2021 •
edited
Loading

Codecov Report

Merging #4272 (bc45172) into main (47d7daf) will decrease coverage by 0.32%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4272      +/-   ##
==========================================
- Coverage   93.06%   92.74%   -0.33%     
==========================================
  Files         296      334      +38     
  Lines       11125    11570     +445     
  Branches     3244     3296      +52     
==========================================
+ Hits        10354    10731     +377     
- Misses        301      366      +65     
- Partials      470      473       +3
Flag Coverage Δ
unittest 92.74% <ø> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...eslint-plugin/src/rules/consistent-type-imports.ts 93.03% <0.00%> (-0.45%) ⬇️
packages/scope-manager/src/lib/index.ts 100.00% <0.00%> (ø)
packages/scope-manager/src/lib/es2021.ts 100.00% <0.00%> (ø)
packages/eslint-plugin/src/rules/no-shadow.ts 76.33% <0.00%> (ø)
...experimental-utils/src/eslint-utils/RuleCreator.ts 80.00% <0.00%> (ø)
...ges/experimental-utils/src/ts-eslint/RuleTester.ts 100.00% <0.00%> (ø)
...rimental-utils/src/ast-utils/eslint-utils/index.ts 100.00% <0.00%> (ø)
...mental-utils/src/ts-eslint-scope/PatternVisitor.ts 100.00% <0.00%> (ø)
...mental-utils/src/eslint-utils/getParserServices.ts 20.00% <0.00%> (ø)
...s/experimental-utils/src/eslint-utils/deepMerge.ts 89.47% <0.00%> (ø)
... and 34 more

@lonyele lonyele changed the title fix(typescript-estree): type-only regression for consumers not yet on TS 4.1 fix(typescript-estree): type-only regression for consumers not yet on TS 4.4 Dec 7, 2021
@lonyele lonyele changed the title fix(typescript-estree): type-only regression for consumers not yet on TS 4.4 fix(typescript-estree): type-only regression for consumers not yet on TS 4.5 Dec 7, 2021
@bradzacher
Copy link
Member

thanks!

@bradzacher bradzacher added the bug Something isn't working label Dec 7, 2021
@bradzacher bradzacher merged commit 550b61e into typescript-eslint:main Dec 7, 2021
@lonyele lonyele deleted the fix/type-only-regression-for-ts-4.4 branch December 17, 2021 10:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@armano2 armano2 armano2 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[5.4.0] Typescript 4.4.4 (latest) not supported anymore
3 participants
@lonyele @bradzacher @armano2