-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix(type-utils): check IndexSignature internals when checking isTypeReadonly #4417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the PR, @RebeccaStevens! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
❌ Deploy Preview for typescript-eslint failed. 🔨 Explore the source changes: 186756a 🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61e523a508b7610007a53db2 |
bb98b9e
to
bea1b72
Compare
920a0af
to
7f79869
Compare
7f79869
to
12aea42
Compare
12aea42
to
957eed4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for fixing this!
…eadonly (typescript-eslint#4417) * fix(type-utils): make isTypeReadonly's options param optional fix typescript-eslint#4410 * test(type-utils): add basic tests for isTypeReadonly * test(type-utils): add test for IndexSignature internals * fix(type-utils): check IndexSignature internals when checking isTypeReadonly fix typescript-eslint#3714 * perf(type-utils): don't test IndexSignature key for readonlyness as it will always be readonly Co-authored-by: Josh Goldberg <joshuakgoldberg@outlook.com>
PR Checklist
Overview
isTypeReadonly
now checks the details of anIndexSignature
; not just the outer readonlyness.Note: This PR builds off #4416