fix(eslint-plugin): [no-unnecessary-type-arguments] Use Symbol to check for the same type #4543

islandryu · 2022-02-12T11:27:59Z

PR Checklist

Addresses an existing issue: fixes [no-unnecessary-type-arguments] Flags a violation for identically-named but different types #4489
That issue was marked as accepting prs
Steps in CONTRIBUTING.md were taken

Overview

Instead of using text to check if the type is the same, it is now checked by symbol.
If there is no symbol, it is checked by typeFlag.
Typescript doesn't provide an api for handling type relationships, does it?

…ck if it's the same type

nx-cloud · 2022-02-12T11:28:02Z

☁️ Nx Cloud Report

CI ran the following commands for commit 5cd23e7. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 48 targets

Sent with 💌 from NxCloud.

typescript-eslint · 2022-02-12T11:28:04Z

Thanks for the PR, @islandryu!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

netlify · 2022-02-12T11:28:09Z

❌ Deploy Preview for typescript-eslint failed.

🔨 Explore the source changes: 5cd23e7

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/62080fb8092d1d0007efef35

codecov · 2022-02-12T11:36:49Z

Codecov Report

Merging #4543 (5cd23e7) into main (d698f6b) will increase coverage by 2.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4543      +/-   ##
==========================================
+ Coverage   92.49%   94.56%   +2.07%     
==========================================
  Files         346      147     -199     
  Lines       11696     7896    -3800     
  Branches     3340     2538     -802     
==========================================
- Hits        10818     7467    -3351     
+ Misses        608      234     -374     
+ Partials      270      195      -75

Flag	Coverage Δ
unittest	`94.56% <100.00%> (+2.07%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...plugin/src/rules/explicit-module-boundary-types.ts	`91.04% <ø> (ø)`
...-plugin/src/rules/no-unnecessary-type-arguments.ts	`98.03% <100.00%> (+0.31%)`	⬆️
...ages/scope-manager/src/lib/es2016.array.include.ts
packages/typescript-estree/src/convert-comments.ts
...ges/scope-manager/src/definition/DefinitionBase.ts
packages/scope-manager/src/lib/esnext.array.ts
...ages/scope-manager/src/referencer/ExportVisitor.ts
packages/scope-manager/src/lib/es7.ts
...t-estree/src/create-program/useProvidedPrograms.ts
packages/scope-manager/src/lib/index.ts
... and 191 more

JoshuaKGoldberg · 2022-02-12T17:58:00Z

Typescript doesn't provide an api for handling type relationships, does it?

https://twitter.com/JoshuaKGoldberg/status/1476738261863346205

microsoft/TypeScript#9879

😢

JoshuaKGoldberg

Nice usage of the compiler APIs. Thanks @islandryu!

Making a mental note that if we keep needing to do these we might want to make a separate function. But this is fine for now.

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.10.2` -> `5.12.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.10.2/5.12.0) | | [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.10.2` -> `5.12.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.10.2/5.12.0) | --- ### Release Notes <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/eslint-plugin)</summary> ### [`v5.12.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#5120-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5110v5120-2022-02-14) [Compare Source](typescript-eslint/typescript-eslint@v5.11.0...v5.12.0) ##### Bug Fixes - **eslint-plugin:** \[init-declarations] fix nested namespace ([#4544](typescript-eslint/typescript-eslint#4544)) ([fe910e6](typescript-eslint/typescript-eslint@fe910e6)) - **eslint-plugin:** \[no-unnecessary-type-arguments] Use Symbol to check if it's the same type ([#4543](typescript-eslint/typescript-eslint#4543)) ([5b7d8df](typescript-eslint/typescript-eslint@5b7d8df)) - support nested object deconstructuring with type annotation ([#4548](typescript-eslint/typescript-eslint#4548)) ([4da9278](typescript-eslint/typescript-eslint@4da9278)) ##### Features - add checking property definition for allowNames option ([#4542](typescript-eslint/typescript-eslint#4542)) ([e32bef6](typescript-eslint/typescript-eslint@e32bef6)) ### [`v5.11.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#5110-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5102v5110-2022-02-07) [Compare Source](typescript-eslint/typescript-eslint@v5.10.2...v5.11.0) ##### Bug Fixes - **eslint-plugin:** \[no-magic-numbers] fix invalid schema merging ([#4517](typescript-eslint/typescript-eslint#4517)) ([b95f796](typescript-eslint/typescript-eslint@b95f796)) - **eslint-plugin:** \[non-nullable-type-assertion-style] fix false positive when asserting to a generic type that might be nullish ([#4509](typescript-eslint/typescript-eslint#4509)) ([4209362](typescript-eslint/typescript-eslint@4209362)) ##### Features - **eslint-plugin:** \[explicit-function-return-type] add allowedNames ([#4440](typescript-eslint/typescript-eslint#4440)) ([936e252](typescript-eslint/typescript-eslint@936e252)) #### [5.10.2](typescript-eslint/typescript-eslint@v5.10.1...v5.10.2) (2022-01-31) ##### Bug Fixes - **eslint-plugin:** \[no-restricted-imports] allow relative type imports with patterns configured ([#4494](typescript-eslint/typescript-eslint#4494)) ([4a6d217](typescript-eslint/typescript-eslint@4a6d217)) #### [5.10.1](typescript-eslint/typescript-eslint@v5.10.0...v5.10.1) (2022-01-24) **Note:** Version bump only for package [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/eslint-plugin) </details> <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/parser)</summary> ### [`v5.12.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#5120-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5110v5120-2022-02-14) [Compare Source](typescript-eslint/typescript-eslint@v5.11.0...v5.12.0) **Note:** Version bump only for package [@typescript-eslint/parser](https://github.com/typescript-eslint/parser) ### [`v5.11.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#5110-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5102v5110-2022-02-07) [Compare Source](typescript-eslint/typescript-eslint@v5.10.2...v5.11.0) **Note:** Version bump only for package [@typescript-eslint/parser](https://github.com/typescript-eslint/parser) #### [5.10.2](typescript-eslint/typescript-eslint@v5.10.1...v5.10.2) (2022-01-31) **Note:** Version bump only for package [@typescript-eslint/parser](https://github.com/typescript-eslint/parser) #### [5.10.1](typescript-eslint/typescript-eslint@v5.10.0...v5.10.1) (2022-01-24) **Note:** Version bump only for package [@typescript-eslint/parser](https://github.com/typescript-eslint/parser) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Co-authored-by: crapStone <crapstone@noreply.codeberg.org> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1157 Reviewed-by: crapStone <crapstone@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

fix(eslint-plugin): [no-unnecessary-type-arguments] Use Symbol to che…

5548b80

…ck if it's the same type

islandryu marked this pull request as ready for review February 12, 2022 12:01

JoshuaKGoldberg approved these changes Feb 12, 2022

View reviewed changes

Merge branch 'main' into fix/identically-namedButDifferentTypes

5cd23e7

JoshuaKGoldberg enabled auto-merge (squash) February 12, 2022 19:51

JoshuaKGoldberg merged commit 5b7d8df into typescript-eslint:main Feb 12, 2022

bradzacher mentioned this pull request Feb 15, 2022

fix(eslint-plugin): [no-unnecessary-type-arguments] fix comparison of types #4555

Merged

3 tasks

nandi95 mentioned this pull request Feb 17, 2022

[@typescript-eslint/no-unnecessary-type-arguments] type argument automatically removed #4569

Closed

3 tasks

github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(eslint-plugin): [no-unnecessary-type-arguments] Use Symbol to check for the same type #4543

fix(eslint-plugin): [no-unnecessary-type-arguments] Use Symbol to check for the same type #4543

islandryu commented Feb 12, 2022 •

edited

Loading

nx-cloud bot commented Feb 12, 2022 •

edited

Loading

typescript-eslint bot commented Feb 12, 2022

netlify bot commented Feb 12, 2022 •

edited

Loading

codecov bot commented Feb 12, 2022 •

edited

Loading

JoshuaKGoldberg commented Feb 12, 2022

JoshuaKGoldberg left a comment

fix(eslint-plugin): [no-unnecessary-type-arguments] Use Symbol to check for the same type #4543

fix(eslint-plugin): [no-unnecessary-type-arguments] Use Symbol to check for the same type #4543

Conversation

islandryu commented Feb 12, 2022 • edited Loading

PR Checklist

Overview

nx-cloud bot commented Feb 12, 2022 • edited Loading

☁️ Nx Cloud Report

typescript-eslint bot commented Feb 12, 2022

netlify bot commented Feb 12, 2022 • edited Loading

codecov bot commented Feb 12, 2022 • edited Loading

Codecov Report

JoshuaKGoldberg commented Feb 12, 2022

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

islandryu commented Feb 12, 2022 •

edited

Loading

nx-cloud bot commented Feb 12, 2022 •

edited

Loading

netlify bot commented Feb 12, 2022 •

edited

Loading

codecov bot commented Feb 12, 2022 •

edited

Loading