Skip to content

feat(eslint-plugin): Add semi [extension] #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2019
Merged

feat(eslint-plugin): Add semi [extension] #461

merged 2 commits into from
Apr 24, 2019

Conversation

bradzacher
Copy link
Member

Fixes #409, #123, #366

@bradzacher bradzacher added the enhancement: new base rule extension New base rule extension required to handle a TS specific case label Apr 23, 2019
Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@codecov
Copy link

codecov bot commented Apr 24, 2019

Codecov Report

Merging #461 into master will decrease coverage by 0.02%.
The diff coverage is 90.9%.

@@            Coverage Diff             @@
##           master     #461      +/-   ##
==========================================
- Coverage   97.09%   97.07%   -0.03%     
==========================================
  Files          74       75       +1     
  Lines        2891     2902      +11     
  Branches      479      479              
==========================================
+ Hits         2807     2817      +10     
- Misses         51       52       +1     
  Partials       33       33
Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/semi.ts 90.9% <90.9%> (ø)

@nstepien
Copy link
Contributor

Great! Looking forward to the next release, I'll finally be able to remove our dependency on the tslint plugin, which we only used for the semicolon rule.

@JamesHenry
Copy link
Member

@MayhemYDG We release on every commit to master, you can check out the README for more details

@kuceb
Copy link

kuceb commented Jun 12, 2019

@bradzacher thanks for this!

I think semicolons are still not detected in interface/object type definitions:

type foo = {
  bar:string;
  baz:number;
}; // <--- only this semicolon is caught

@bradzacher
Copy link
Member Author

@bkucera - feel free to raise an issue with more concrete examples and config, and we can look into it.

Old merged PR's aren't great for this kind of discussion.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement: new base rule extension New base rule extension required to handle a TS specific case
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[semi] Doesn't seem to apply to class members
4 participants