-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat(eslint-plugin): Add semi [extension] #461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Codecov Report
@@ Coverage Diff @@
## master #461 +/- ##
==========================================
- Coverage 97.09% 97.07% -0.03%
==========================================
Files 74 75 +1
Lines 2891 2902 +11
Branches 479 479
==========================================
+ Hits 2807 2817 +10
- Misses 51 52 +1
Partials 33 33
|
Great! Looking forward to the next release, I'll finally be able to remove our dependency on the tslint plugin, which we only used for the |
@MayhemYDG We release on every commit to master, you can check out the README for more details |
@bradzacher thanks for this! I think semicolons are still not detected in interface/object type definitions: type foo = {
bar:string;
baz:number;
}; // <--- only this semicolon is caught |
@bkucera - feel free to raise an issue with more concrete examples and config, and we can look into it. Old merged PR's aren't great for this kind of discussion. |
Fixes #409, #123, #366