Skip to content

chore: wip #4664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

chore: wip #4664

wants to merge 6 commits into from

Conversation

JamesHenry
Copy link
Member

No description provided.

@nx-cloud
Copy link

nx-cloud bot commented Mar 10, 2022

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JamesHenry!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Mar 10, 2022

✔️ Deploy Preview for typescript-eslint ready!

🔨 Explore the source changes: d98ba34

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/6229e3b98d089f000a96f7eb

😎 Browse the preview: https://deploy-preview-4664--typescript-eslint.netlify.app

@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #4664 (d98ba34) into main (cf325ce) will decrease coverage by 2.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4664      +/-   ##
==========================================
- Coverage   94.25%   92.14%   -2.11%     
==========================================
  Files         151      351     +200     
  Lines        7971    11640    +3669     
  Branches     2573     3376     +803     
==========================================
+ Hits         7513    10726    +3213     
- Misses        262      646     +384     
- Partials      196      268      +72     
Flag Coverage Δ
unittest 92.14% <100.00%> (-2.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/typescript-estree/src/convert.ts 98.37% <100.00%> (ø)
packages/scope-manager/src/scope/ClassScope.ts 100.00% <0.00%> (ø)
packages/scope-manager/src/referencer/Visitor.ts 100.00% <0.00%> (ø)
packages/utils/src/ts-eslint/ParserOptions.ts 0.00% <0.00%> (ø)
...ages/scope-manager/src/lib/es2016.array.include.ts 100.00% <0.00%> (ø)
packages/type-utils/src/isUnsafeAssignment.ts 84.00% <0.00%> (ø)
...utils/src/ast-utils/eslint-utils/PatternMatcher.ts 100.00% <0.00%> (ø)
...-internal/src/rules/no-typescript-estree-import.ts 87.50% <0.00%> (ø)
packages/scope-manager/src/assert.ts 33.33% <0.00%> (ø)
packages/utils/src/eslint-utils/applyDefault.ts 100.00% <0.00%> (ø)
... and 191 more

@bradzacher bradzacher added the repo maintenance things to do with maintenance of the repo, and not with code/docs label Mar 10, 2022
@JamesHenry
Copy link
Member Author

Closing in favour of my branch that leverages Nx more directly per #4665

@JamesHenry JamesHenry closed this Mar 21, 2022
@JamesHenry JamesHenry deleted the nx-cloud-dte branch March 21, 2022 08:29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants