Skip to content

chore: refactor scope-manager config to be closer to nx OOTB #4788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 12, 2022
Merged

chore: refactor scope-manager config to be closer to nx OOTB #4788

merged 3 commits into from
Apr 12, 2022

Conversation

JamesHenry
Copy link
Member

@JamesHenry JamesHenry commented Apr 4, 2022 •
edited
Loading

Refs: #4665

I was initially working through all projects simultaneously but it became clear that reviewing the ultimate PR from that would be an absolute nightmare, so I am instead going to approach it project by project (with some follow on work to then optimize once all have been largely transitioned, e.g. by pulling code from source for tests to make them faster and no longer require a full build before running)

And sorry, specifically for scope-manager we have some noise for the generated code because of changing the instructions for regenerating them. This will not be the case for other projects

@nx-cloud
Copy link

nx-cloud bot commented Apr 4, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7837ccf. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 43 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JamesHenry!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Apr 4, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 7837ccf
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/625162adff9b1a00099e819d
😎 Deploy Preview https://deploy-preview-4788--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Apr 4, 2022 •
edited
Loading

Codecov Report

Merging #4788 (7837ccf) into main (4c428c5) will decrease coverage by 2.48%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4788      +/-   ##
==========================================
- Coverage   94.27%   91.78%   -2.49%     
==========================================
  Files         151      226      +75     
  Lines        8220    10548    +2328     
  Branches     2672     3259     +587     
==========================================
+ Hits         7749     9681    +1932     
- Misses        262      590     +328     
- Partials      209      277      +68
Flag Coverage Δ
unittest 91.78% <ø> (-2.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...estree/src/create-program/createIsolatedProgram.ts 75.00% <0.00%> (ø)
packages/type-utils/src/getDeclaration.ts 0.00% <0.00%> (ø)
packages/utils/src/ts-eslint-scope/Variable.ts 100.00% <0.00%> (ø)
packages/type-utils/src/typeFlagUtils.ts 83.33% <0.00%> (ø)
...s/utils/src/eslint-utils/batchedSingleLineTests.ts 91.66% <0.00%> (ø)
packages/utils/src/ts-eslint-scope/ScopeManager.ts 100.00% <0.00%> (ø)
...-estree/src/create-program/createProjectProgram.ts 94.11% <0.00%> (ø)
packages/type-utils/src/getTypeName.ts 0.00% <0.00%> (ø)
packages/utils/src/ast-utils/helpers.ts 68.18% <0.00%> (ø)
packages/typescript-estree/src/node-utils.ts 98.29% <0.00%> (ø)
... and 65 more

@JamesHenry JamesHenry marked this pull request as ready for review April 4, 2022 09:52
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes Apr 8, 2022
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm very unfamiliar with NX but reading through the docs and playing with this locally, it seems reasonable!

bradzacher
bradzacher reviewed Apr 9, 2022
View reviewed changes
@bradzacher bradzacher added the repo maintenance things to do with maintenance of the repo, and not with code/docs label Apr 9, 2022
@JamesHenry
Copy link
Member Author

JamesHenry commented Apr 11, 2022 •
edited
Loading

I'm just holding off on merging while I discuss the need for the cd ../../ in the aliases, it's not actually expected that those are necessary. I suspect it might have to do with our usage of the @typescript-eslint/ within the nx project names

@JamesHenry
Copy link
Member Author

Ok confirmed with Victor that this is required for now

@JamesHenry JamesHenry merged commit 18a81cb into main Apr 12, 2022
@JamesHenry JamesHenry deleted the scope-manager-nx branch April 12, 2022 07:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

@bradzacher bradzacher Awaiting requested review from bradzacher

Assignees
No one assigned
Labels
repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JamesHenry @JoshuaKGoldberg @bradzacher