feat: [4.7] support new extensions #5027

bradzacher · 2022-05-20T16:56:23Z

PR Checklist

Addresses an existing open issue: fixes TypeScript 4.7 Support #4800
That issue was marked as accepting prs
Steps in CONTRIBUTING.md were taken

Overview

This was mostly a find and manual update to include the new extensions.
I made a few tweaks to the code to make it more maintainable as well (like using TS's Extension enum)

nx-cloud · 2022-05-20T16:56:25Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e2620c5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

typescript-eslint · 2022-05-20T16:56:29Z

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

netlify · 2022-05-20T16:56:30Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`e2620c5`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/628d61980ee66f0009b07165
😎 Deploy Preview	https://deploy-preview-5027--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

docs/linting/README.md

JoshuaKGoldberg · 2022-05-20T20:46:51Z

packages/eslint-plugin/src/util/misc.ts

+      return true;
+    }
+  }
+  return false;


Nit: you could return DEFINITION_EXTENSIONS.some(extension => fileName.endsWith(extension)). If you wanted.

docs/linting/TROUBLESHOOTING.md

Josh-Cena · 2022-05-22T13:24:13Z

packages/experimental-utils/package.json

@@ -33,8 +33,8 @@
    "postbuild": "downlevel-dts dist _ts3.4/dist",
    "clean": "tsc -b tsconfig.build.json --clean",
    "postclean": "rimraf dist && rimraf _ts3.4 && rimraf coverage",
-    "format": "prettier --write \"./**/*.{ts,js,json,md}\" --ignore-path ../../.prettierignore",
-    "lint": "eslint . --ext .js,.ts --ignore-path='../../.eslintignore'",
+    "format": "prettier --write \"./**/*.{ts,mts,cts,tsx,js,mjs,cjs,jsx,json,md,css}\" --ignore-path ../../.prettierignore",


Unless I'm missing something, we can use prettier --write \"./**/*\" --ignore-unknown --ignore-path ../../.prettierignore?

I think we did this to control the files that get formatted... I forget exactly - it's been so long!
So I just kept it as is. I don't know if we really need to bother with this now.

JoshuaKGoldberg

Looks great, only little non-blockers from me!

packages/typescript-estree/src/parser.ts

packages/typescript-estree/src/create-program/shared.ts

docs/linting/README.md

docs/linting/TROUBLESHOOTING.md

packages/parser/README.md

packages/typescript-estree/src/create-program/getScriptKind.ts

Co-authored-by: Josh Goldberg <me@joshuakgoldberg.com>

codecov · 2022-05-24T23:11:55Z

Codecov Report

Merging #5027 (e2620c5) into main (9f3121b) will increase coverage by 2.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5027      +/-   ##
==========================================
+ Coverage   91.68%   93.81%   +2.12%     
==========================================
  Files         361      286      -75     
  Lines       12128     9811    -2317     
  Branches     3521     2933     -588     
==========================================
- Hits        11120     9204    -1916     
+ Misses        658      328     -330     
+ Partials      350      279      -71

Flag	Coverage Δ
unittest	`93.81% <100.00%> (+2.12%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...es/eslint-plugin/src/configs/eslint-recommended.ts	`100.00% <ø> (ø)`
packages/eslint-plugin/src/util/misc.ts	`96.42% <100.00%> (+2.42%)`	⬆️
...estree/src/create-program/createIsolatedProgram.ts
...-estree/src/create-program/createProjectProgram.ts
...ript-estree/src/create-program/createSourceFile.ts
...ges/typescript-estree/src/create-program/shared.ts
packages/typescript-estree/src/convert-comments.ts
packages/utils/src/ts-eslint-scope/Referencer.ts
...internal/src/rules/no-typescript-default-import.ts
...ges/utils/src/ast-utils/eslint-utils/predicates.ts
... and 69 more

typescript-eslint/typescript-eslint#5027

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.26.0` -> `5.27.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.26.0/5.27.0) | | [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.26.0` -> `5.27.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.26.0/5.27.0) | --- ### Release Notes <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/eslint-plugin)</summary> ### [`v5.27.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#5270-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5260v5270-2022-05-30) [Compare Source](typescript-eslint/typescript-eslint@v5.26.0...v5.27.0) ##### Bug Fixes - **eslint-plugin:** \[no-type-alias] handle Template Literal Types ([#5092](typescript-eslint/typescript-eslint#5092)) ([8febf11](typescript-eslint/typescript-eslint@8febf11)) ##### Features - \[4.7] support new extensions ([#5027](typescript-eslint/typescript-eslint#5027)) ([efc147b](typescript-eslint/typescript-eslint@efc147b)) - **eslint-plugin:** \[ban-ts-comment] add descriptionFormat option ([#5026](typescript-eslint/typescript-eslint#5026)) ([1fb31a4](typescript-eslint/typescript-eslint@1fb31a4)) - **eslint-plugin:** \[no-misused-promises] warn when spreading promises ([#5053](typescript-eslint/typescript-eslint#5053)) ([61ffa9e](typescript-eslint/typescript-eslint@61ffa9e)) - **eslint-plugin:** \[space-infix-ops] missing error report for conditional types ([#5041](typescript-eslint/typescript-eslint#5041)) ([0bfab6c](typescript-eslint/typescript-eslint@0bfab6c)) </details> <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/parser)</summary> ### [`v5.27.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#5270-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5260v5270-2022-05-30) [Compare Source](typescript-eslint/typescript-eslint@v5.26.0...v5.27.0) ##### Bug Fixes - **types:** remove leftovers from removal of useJSXTextNode ([#5091](typescript-eslint/typescript-eslint#5091)) ([f9c3647](typescript-eslint/typescript-eslint@f9c3647)) ##### Features - \[4.7] support new extensions ([#5027](typescript-eslint/typescript-eslint#5027)) ([efc147b](typescript-eslint/typescript-eslint@efc147b)) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1385 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

bradzacher added the enhancement New feature or request label May 20, 2022

JoshuaKGoldberg reviewed May 20, 2022

View reviewed changes

docs/linting/README.md Outdated Show resolved Hide resolved

JoshuaKGoldberg reviewed May 20, 2022

View reviewed changes

feat: [4.7] support new extensions

b654707

bradzacher force-pushed the 4.7-new-extensions branch from 3292002 to b654707 Compare May 20, 2022 23:46

Josh-Cena reviewed May 22, 2022

View reviewed changes

docs/linting/TROUBLESHOOTING.md Outdated Show resolved Hide resolved

Josh-Cena reviewed May 22, 2022

View reviewed changes

Update TROUBLESHOOTING.md

b561a5a

bradzacher mentioned this pull request May 23, 2022

chore(website): rewrite WebLinter to typescript and fix support for ts 4.7 #5034

Merged

3 tasks

JoshuaKGoldberg previously approved these changes May 23, 2022

View reviewed changes

Update docs/linting/TROUBLESHOOTING.md

e34a00e

Co-authored-by: Josh Goldberg <me@joshuakgoldberg.com>

bradzacher dismissed JoshuaKGoldberg’s stale review via e34a00e May 23, 2022 21:39

bradzacher and others added 5 commits May 23, 2022 14:40

Update docs/linting/TROUBLESHOOTING.md

d02f76c

Co-authored-by: Josh Goldberg <me@joshuakgoldberg.com>

Update packages/parser/README.md

8e3bec4

Co-authored-by: Josh Goldberg <me@joshuakgoldberg.com>

Update getScriptKind.ts

9203072

review fixes

2a509b5

fix test

e2620c5

bradzacher merged commit efc147b into main May 24, 2022

bradzacher deleted the 4.7-new-extensions branch May 24, 2022 23:11

armano2 added a commit that referenced this pull request May 24, 2022

chore(website): update link to getScriptKind base on changes from #5027

a46048a

turadg added a commit to Agoric/agoric-sdk that referenced this pull request May 31, 2022

chore: default extensions for eslint

27b6045

typescript-eslint/typescript-eslint#5027

turadg added a commit to Agoric/agoric-sdk that referenced this pull request May 31, 2022

chore: default extensions for eslint

eabc30a

typescript-eslint/typescript-eslint#5027

turadg added a commit to Agoric/agoric-sdk that referenced this pull request May 31, 2022

chore: default extensions for eslint

b272a9a

typescript-eslint/typescript-eslint#5027

turadg added a commit to Agoric/agoric-sdk that referenced this pull request Jun 1, 2022

chore: default extensions for eslint

36c46fc

typescript-eslint/typescript-eslint#5027

turadg added a commit to Agoric/agoric-sdk that referenced this pull request Jun 1, 2022

chore: default extensions for eslint

00ae7c4

typescript-eslint/typescript-eslint#5027

turadg added a commit to Agoric/agoric-sdk that referenced this pull request Jun 1, 2022

chore: default extensions for eslint

bd40552

typescript-eslint/typescript-eslint#5027

turadg added a commit to Agoric/agoric-sdk that referenced this pull request Jun 1, 2022

chore: default extensions for eslint

d8c1636

typescript-eslint/typescript-eslint#5027

github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: [4.7] support new extensions #5027

feat: [4.7] support new extensions #5027

bradzacher commented May 20, 2022

nx-cloud bot commented May 20, 2022 •

edited

Loading

typescript-eslint bot commented May 20, 2022

netlify bot commented May 20, 2022 •

edited

Loading

JoshuaKGoldberg May 20, 2022

Josh-Cena May 22, 2022

bradzacher May 22, 2022

JoshuaKGoldberg left a comment

codecov bot commented May 24, 2022 •

edited

Loading

feat: [4.7] support new extensions #5027

feat: [4.7] support new extensions #5027

Conversation

bradzacher commented May 20, 2022

PR Checklist

Overview

nx-cloud bot commented May 20, 2022 • edited Loading

☁️ Nx Cloud Report

typescript-eslint bot commented May 20, 2022

netlify bot commented May 20, 2022 • edited Loading

✅ Deploy Preview for typescript-eslint ready!

JoshuaKGoldberg May 20, 2022

Choose a reason for hiding this comment

Josh-Cena May 22, 2022

Choose a reason for hiding this comment

bradzacher May 22, 2022

Choose a reason for hiding this comment

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

codecov bot commented May 24, 2022 • edited Loading

Codecov Report

nx-cloud bot commented May 20, 2022 •

edited

Loading

netlify bot commented May 20, 2022 •

edited

Loading

codecov bot commented May 24, 2022 •

edited

Loading