Skip to content

chore(website): rewrite WebLinter to typescript and fix support for ts 4.7 #5034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 24, 2022
Merged

chore(website): rewrite WebLinter to typescript and fix support for ts 4.7 #5034

merged 8 commits into from
May 24, 2022

Conversation

armano2
Copy link
Collaborator

@armano2 armano2 commented May 22, 2022 •
edited
Loading

PR Checklist

Overview

related to: #4765 (review) #4765 (comment)

armano2 added 2 commits May 22, 2022 17:21
@armano2
chore(website): rewrite web linter to typescript
652376f 
- reuse Linter instance
- reuse virtual CompilerHost and use utilize typescript-vfs
- update ecmaVersion to latest
- correct minor issue in ESLintParseResult
@armano2
chore(website): correct issues with ts ^4.7-beta
f7d33b4
@nx-cloud
Copy link

nx-cloud bot commented May 22, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a46048a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented May 22, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit a46048a
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/628d6a7dacdc8400080adbd3
😎 Deploy Preview https://deploy-preview-5034--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@armano2 armano2 added enhancement New feature or request package: website Issues related to the @typescript-eslint website labels May 22, 2022
@armano2 armano2 changed the title chore(website): rewrite webLiner chore(website): rewrite webLiner to typescript and fix support for ts 4.7 May 22, 2022
@codecov
Copy link

codecov bot commented May 23, 2022 •
edited
Loading

Codecov Report

Merging #5034 (a46048a) into main (d214556) will increase coverage by 0.21%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5034      +/-   ##
==========================================
+ Coverage   91.32%   91.53%   +0.21%     
==========================================
  Files         132      343     +211     
  Lines        1487    10750    +9263     
  Branches      224     3147    +2923     
==========================================
+ Hits         1358     9840    +8482     
- Misses         65      588     +523     
- Partials       64      322     +258
Flag Coverage Δ
unittest 91.53% <ø> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/utils/src/ts-eslint/Linter.ts 100.00% <ø> (ø)
packages/utils/src/ts-eslint-scope/Definition.ts 100.00% <0.00%> (ø)
...nt-plugin/src/rules/indent-new-do-not-use/index.ts 98.09% <0.00%> (ø)
...slint-plugin/src/rules/prefer-enum-initializers.ts 100.00% <0.00%> (ø)
.../src/rules/sort-type-union-intersection-members.ts 90.74% <0.00%> (ø)
packages/utils/src/eslint-utils/applyDefault.ts 100.00% <0.00%> (ø)
...s/eslint-plugin/src/util/collectUnusedVariables.ts 93.19% <0.00%> (ø)
.../eslint-plugin/src/rules/triple-slash-reference.ts 100.00% <0.00%> (ø)
...ckages/eslint-plugin/src/rules/no-magic-numbers.ts 80.64% <0.00%> (ø)
packages/eslint-plugin/src/rules/dot-notation.ts 96.29% <0.00%> (ø)
... and 202 more

@armano2
Copy link
Collaborator Author

armano2 commented May 24, 2022

as for imports, for now we should keep them as they are, and as for getScriptKind, I imported it from typescript-estree, in separate PR we should think about adding terser or uglify to build pipeline for website-eslint package sandbox/index.js

@armano2
Copy link
Collaborator Author

armano2 commented May 24, 2022

getScriptKind updated to take advantage of changes from #5027

@armano2 armano2 requested a review from bradzacher May 24, 2022 23:32
@bradzacher bradzacher changed the title chore(website): rewrite webLiner to typescript and fix support for ts 4.7 chore(website): rewrite WebLinter to typescript and fix support for ts 4.7 May 24, 2022
@bradzacher bradzacher merged commit 519dd7b into main May 24, 2022
@bradzacher bradzacher deleted the feat/refactor-and-convert-sandbox-to-ts branch May 24, 2022 23:49
This was referenced May 25, 2022
Closed
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request package: website Issues related to the @typescript-eslint website
Projects
No open projects
Website Playground
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@armano2 @bradzacher