Skip to content

chore(website): pass user defined compilerOptions to linter #5080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 26, 2022
Merged

chore(website): pass user defined compilerOptions to linter #5080

merged 3 commits into from
May 26, 2022

Conversation

armano2
Copy link
Collaborator

@armano2 armano2 commented May 25, 2022 •
edited
Loading

PR Checklist

Overview

  • fixes issue with playground not respecting jsx options

    web-linter parsed code but you could see error in editor
    const x = <Boo>this.foo();
    Note: changing from and to JSX support in editor requires browser refresh, this is limitation of sandbox

  • allow user-defined compilerOptions to be passed to WebLinter

    regression fix for bug introduced in chore(website): rewrite WebLinter to typescript and fix support for ts 4.7 #5034

Test cases

@armano2 armano2 added bug Something isn't working package: website Issues related to the @typescript-eslint website labels May 25, 2022
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@nx-cloud
Copy link

nx-cloud bot commented May 25, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 38bbef9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented May 25, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 38bbef9
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/628f9f75a0bcb1000ab52d04
😎 Deploy Preview https://deploy-preview-5080--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@armano2 armano2 requested a review from bradzacher May 25, 2022 18:43
bradzacher
bradzacher previously approved these changes May 26, 2022
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One quick request - could we makestrict: true the default?
Or at least strictNullChecks.

Otherwise
lgtm15.jpg

@armano2
Copy link
Collaborator Author

armano2 commented May 26, 2022 •
edited
Loading

One quick request - could we makestrict: true the default? Or at least strictNullChecks.

sadly no, we can't really define defaults, user is not going to be able to disable them for now, changing defaults requires changes to be done in config editor, but that will be done when i get to improving config editor

Config editor currently removes all options that are set to false (yes this is bad, but that's how it was done)

added to backlog, Website Playground (view)

@bradzacher bradzacher changed the title fix(website): pass user defined compilerOptions to linter chore(website): pass user defined compilerOptions to linter May 26, 2022
@bradzacher bradzacher merged commit 594116e into main May 26, 2022
@bradzacher bradzacher deleted the fix/playground-compiler-options-sync branch May 26, 2022 15:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher left review comments

Assignees
No one assigned
Labels
bug Something isn't working package: website Issues related to the @typescript-eslint website website: playground
Projects
No open projects
Website Playground
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug(website): compiler options are not passed to the lint run
2 participants
@armano2 @bradzacher